Skip to content

Fix dodal for triggerable command#2091

Draft
rtuck99 wants to merge 16 commits into
mainfrom
fix_dodal_for_triggerable_command
Draft

Fix dodal for triggerable command#2091
rtuck99 wants to merge 16 commits into
mainfrom
fix_dodal_for_triggerable_command

Conversation

@rtuck99

@rtuck99 rtuck99 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Removes deprecated usage of SignalX in favour of TriggerableCommand

Requires

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Base automatically changed from fix_for_latest_ophyd_async_2nd_attempt to main June 12, 2026 09:03
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (7916b43) to head (ce03515).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         344      344           
  Lines       13388    13388           
=======================================
  Hits        13274    13274           
  Misses        114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants