Fix for latest ophyd async 2nd attempt#2090
Merged
Merged
Conversation
…ed_signals to use the readback signals of motors
DominicOram
approved these changes
Jun 11, 2026
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Great, thank you! I think this looks good, once ophyd-async makes it on to pypi. One minor nit in code, take it or leave it
| "ignore:dep_util is Deprecated. Use functions from setuptools instead.:DeprecationWarning", | ||
| # Ignore deprecation warning from zocalo | ||
| "ignore:.*pkg_resources.*:DeprecationWarning", | ||
| "ignore:epics_signal_x is deprecated, use epics_triggerable_command instead:DeprecationWarning", |
Contributor
There was a problem hiding this comment.
Could: Can you add a link to the PR/issue that removes this
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2090 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 344 344
Lines 13374 13388 +14
=======================================
+ Hits 13260 13274 +14
Misses 114 114 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
Fixes for updates in ophyd-async 0.18
Requires
Fix derived signal all read only throwing error with rd plan bluesky/ophyd-async#1290Does not include changes for
TriggerableCommandthese will be included in another PR TBCInstructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}