Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
- Coverage 99.14% 99.14% -0.01%
==========================================
Files 344 344
Lines 13388 13387 -1
==========================================
- Hits 13274 13273 -1
Misses 114 114 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DominicOram
requested changes
Jun 12, 2026
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Great, thanks. Could you add a unit test that would have caught this?
DominicOram
approved these changes
Jun 12, 2026
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
One nit, take it or leave it. Thanks!
| laue_monochrometer: LaueMonochrometer, | ||
| ): | ||
| result = await laue_monochrometer.read() | ||
| assert list(result.keys()) == ["monocrometer-energy_kev"] |
Contributor
There was a problem hiding this comment.
Nit: Might be better to use assert_reading here
Contributor
Author
There was a problem hiding this comment.
Good spot thanks, in fact I can delete this test and just use full_match=True on the test that already exists which fails if there are other signals in the reading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LaueMonochrometerwas had all of its signals as hinted signals, meaning an error was thrown when trying to read it as which signal to read could not be determined. This fixes it by makingenergy_kevthe only hinted signal.Also, removes the
force_parseroption from the config server request, as the required PR has been merged + released.Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}