Skip to content

AreaDetector for electron analysers#2088

Open
oliwenmandiamond wants to merge 46 commits into
mainfrom
areadetector_for_electron_analysers
Open

AreaDetector for electron analysers#2088
oliwenmandiamond wants to merge 46 commits into
mainfrom
areadetector_for_electron_analysers

Conversation

@oliwenmandiamond

@oliwenmandiamond oliwenmandiamond commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixes #2084.

Instructions to reviewer on how to test:

  1. Check implementation makes sense.
  2. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond changed the base branch from main to fix_for_latest_ophyd_async June 10, 2026 16:06
@oliwenmandiamond oliwenmandiamond changed the title Areadetector for electron analysers AreaDetector for electron analysers Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (7916b43) to head (7ad5c10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2088   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         344      344           
  Lines       13388    13403   +15     
=======================================
+ Hits        13274    13289   +15     
  Misses        114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond oliwenmandiamond marked this pull request as ready for review June 11, 2026 09:25
@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner June 11, 2026 09:25
@oliwenmandiamond oliwenmandiamond changed the base branch from fix_for_latest_ophyd_async to main June 12, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert electron analysers to use AreaDetector

2 participants