Skip to content

Pass the plugins on from i22's detectors#2077

Merged
DominicOram merged 2 commits into
mainfrom
correctly_add_stats_plugins
Jun 12, 2026
Merged

Pass the plugins on from i22's detectors#2077
DominicOram merged 2 commits into
mainfrom
correctly_add_stats_plugins

Conversation

@DominicOram

Copy link
Copy Markdown
Contributor

From testing on i22 we found that the stats plugin wasn't actually getting associated with the detectors. This passes it on properly. This was also masking the issue in bluesky/ophyd-async#1278

Instructions to reviewer on how to test:

  1. Run dodal connect i22 on this branch and confirm it fails
  2. Switch over your ophyd-async to use Only use the RBV PV for the read only signals in the stats plugin bluesky/ophyd-async#1278, confirm dodal connect passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram requested a review from a team as a code owner May 29, 2026 17:04
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (aabd043) to head (61ee095).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2077   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         344      344           
  Lines       13387    13387           
=======================================
  Hits        13273    13273           
  Misses        114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RJCD-Diamond RJCD-Diamond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@DominicOram

Copy link
Copy Markdown
Contributor Author

Probably worth doing #2080 before the merge so as not to break things

@DominicOram DominicOram merged commit a979c80 into main Jun 12, 2026
11 checks passed
@DominicOram DominicOram deleted the correctly_add_stats_plugins branch June 12, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants