Lazy auto-generate + bind v3 payout wallet on first API call#10
Open
epanonymous wants to merge 5 commits into
Open
Lazy auto-generate + bind v3 payout wallet on first API call#10epanonymous wants to merge 5 commits into
epanonymous wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
already_boundas success, and caches the bound state per API key.payoutWallet.pubkey,payoutWallet.publicKey, orpayout_pubkey, plus configurablepayoutWalletStorePathandpayoutWalletApiBase.Supersedes #9
This supersedes PR #9's registration-time / opt-in payout wallet binding model. PR #9 should be closed in favor of this lazy, automatic first-call binding flow.
Shared Contract
GET /api/v1/agent/payout-walletwith agent-key auth returns{ payout_pubkey: base58|null, bound_at: iso|null }.POST /api/v1/agent/payout-wallet/bindwith agent-key auth and body{ payout_pubkey }returns{ payout_pubkey, bound_at, already_bound }.Local Secret Storage
~/.deva/payout-wallet.jsonby default; callers can override this withpayoutWalletStorePath.0700and the store file with0600where supported.{ payout_pubkey }.Verification
npm test(46 passing tests; HTTP calls mocked, no live API)npm run buildcjs lazy payout smoke ok: status=1 bind=1 resources=2