fix: handle legacy version strings in compromised email domain rule (#389)#798
Merged
christophetd merged 3 commits intoJul 8, 2026
Merged
Conversation
Contributor
|
@patchwright Thanks for the contribution! Let me have a look and add a quick unit test to it |
christophetd
approved these changes
Jul 8, 2026
…omain version.parse raises InvalidVersion on non-PEP-440 strings (e.g. pytz '2004d') since packaging 22.0 removed LegacyVersion. This crashed the entire rule when scanning packages with legacy version history. Add _safe_version_key that catches InvalidVersion and sorts legacy versions as oldest (version 0) instead of crashing. Fixes DataDog#389. Assisted-by: Claude (Anthropic). Co-Authored-By: claude-flow <ruv@ruv.net>
christophetd
force-pushed
the
fix/legacy-version-crash-389
branch
from
3abdd8f to
a9cc234
Compare
christophetd
approved these changes
Jul 8, 2026
sobregosodd
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389. version.parse raises InvalidVersion on non-PEP-440 strings (e.g. pytz 2004d) since packaging 22.0. Added _safe_version_key that catches InvalidVersion and sorts legacy versions as oldest. Verified: no crash on 2004d, invalid!, empty string.
Assisted-by: Claude (Anthropic).