Skip to content

Catroid 1661 - Fixed empty parameterized test data#5226

Open
moe-threeface wants to merge 2 commits into
Catrobat:developfrom
moe-threeface:CATROID-1661
Open

Catroid 1661 - Fixed empty parameterized test data#5226
moe-threeface wants to merge 2 commits into
Catrobat:developfrom
moe-threeface:CATROID-1661

Conversation

@moe-threeface

Copy link
Copy Markdown
Contributor

This PR adds a reusable helper to fail parameterized tests explicitly when dynamically collected test data is empty.

Applied to:

  • BricksHelpUrlTest, which discovers Brick classes via DexFile
  • CatrobatTestRunner, which collects .catrobat test assets recursively

I checked the remaining @Parameterized.Parameters usages. They use explicit static test data and were intentionally left unchanged.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • [x ] Include the name of the Jira ticket in the PR’s title
  • [x ] Include a summary of the changes plus the relevant context
  • [ x] Choose the proper base branch (develop)
  • [ x] Confirm that the changes follow the project’s coding guidelines
  • [ x] Verify that the changes generate no compiler or linter warnings
  • [x ] Perform a self-review of the changes
  • [ x] Verify to commit no other files than the intentionally changed ones
  • [x ] Include reasonable and readable tests verifying the added or changed behavior
  • [x ] Confirm that new and existing unit tests pass locally
  • [x ] Check that the commits’ message style matches the project’s guideline
  • [x ] Stick to the project’s gitflow workflow
  • [x ] Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant