CATROID-1667 Select the embroidery AI Tutor prompt for the Embroidery Designer flavor#5223
Open
harissabil wants to merge 1 commit into
Open
CATROID-1667 Select the embroidery AI Tutor prompt for the Embroidery Designer flavor#5223harissabil wants to merge 1 commit into
harissabil wants to merge 1 commit into
Conversation
harissabil
changed the title
harissabil
changed the title
harissabil
changed the title
… Designer flavor Pocket Code and the Embroidery Designer flavor share the same AI Tutor overlay, but Embroidery Designer needs its own brick vocabulary instead of the generic Pocket Code prompt. - AiAssistFlow now passes a PromptVersion to AiTutorView: PromptVersion.EMBROIDERY_SPRITE when BuildConfig.FLAVOR == Constants.FLAVOR_EMBROIDERY_DESIGNER, else PromptVersion.POCKET_CODE_SPRITE. - Fix a whitespace inconsistency in AiAssistOverlay. Targets explore-ai-tutor-integration rather than dev-ai-tutor, since the aiassist package hasn't landed on dev-ai-tutor yet.
harissabil
force-pushed
the
ai-tutor-embroidery-variant-check
branch
from
994d6b2 to
a08b0b6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selects the AI Tutor prompt based on the build flavor so the Embroidery Designer build offers the embroidery brick vocabulary instead of the generic Pocket Code one.
AiAssistFlownow passespromptVersiontoAiTutorView:PromptVersion.EMBROIDERY_SPRITEwhenBuildConfig.FLAVOR == Constants.FLAVOR_EMBROIDERY_DESIGNER, otherwisePromptVersion.POCKET_CODE_SPRITE.explore-ai-tutor-integration(the AI Tutor first integration PR) and targets it, since theaiassistpackage isn't indev-ai-tutoryet.Note for reviewers (building locally)
This branch depends on the AI Tutor library (
org.catrobat:aitutor), which is resolved from your Maven Local repository. To build, you first need to publish it locally:integration/pocket-codebranch: https://github.com/Catrobat/catrobat-ai-tutor/tree/integration/pocket-code./gradlew publishToMavenLocal@harissabil - ping me on Slack if the local install gives you any trouble and I'll walk you through it.
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.