Skip to content

removing a requirement that Edit Requests have to move the request to… - #35

Merged
cheinrichs-oddball merged 2 commits into
mainfrom
NOREF/Bug-Fix-Edit-Request-Is-Forced-To-Change-Steps
Aug 6, 2026
Merged

removing a requirement that Edit Requests have to move the request to…#35
cheinrichs-oddball merged 2 commits into
mainfrom
NOREF/Bug-Fix-Edit-Request-Is-Forced-To-Change-Steps

Conversation

@cheinrichs-oddball

@cheinrichs-oddball cheinrichs-oddball commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

… a new step. Edit requests need to happen back and forth between requester and admin without leaving a process step

PPE-80

Power Platform scope

App / Solution:
Environment(s) impacted:
Change type (check all that apply):

  • Model-driven app (forms/views/commands)
  • Web resources (JS/HTML/CSS/images)
  • Dataverse schema (tables/columns/relationships/choices)
  • Business logic (Business Rules / Power Automate / Workflows)
  • Plugins (C# / registered steps)
  • Data migration (dataflows / M scripts / scripts)
  • Security (roles/teams/field security)
  • Integrations (connections / connectors / DLP)
  • Other:

Description

Currently in the app, an Admin can't submit Edit Requests without changing the Process Step of the Request. This is not the desired behavior, so in this pull request, we've removed a limitation in the plugin that was forcing a step change for Edit Reqeuests. That rule enforcement should still exist on the "Progress to a new step" action.

What changed

Made a small change in the plugin code for Activity Logs.

Deployment notes

  • Delivery mechanism:
  • Solution name + version:
  • Manual steps required:
  • Secrets / connections / DLP needed:
  • Rollback plan:

How to test this change

  1. Go to a Review with an Active Request and choose "Edit Request".
  2. Find the current stage of the Request, and make sure to select that in the "Which form needs edits?" field.
  3. Enter form data, and save and close the window.
  4. See that there is no error popup and the action completes successfully.
  5. If you see the Request, it should display the new Edit Request.

Verified in environment(s)

  • Dev

Risk / impact

  • Data impact: N/A
  • Backward compatibility: N/A
  • Performance considerations: If anything, improves performance a little bit.

PR Author Checklist

  • I described what changed and why.
  • I included clear test steps and validated in at least one environment.
  • I updated documentation/README if this changes how we deploy or develop.
  • If schema changed, I noted the Solution + components affected.
  • If plugin changed, I noted the message/step/stage and confirmed it runs as expected.
  • If data migration/dataflow changed, I tested with representative data.
  • No secrets, tokens, or environment-specific IDs were committed.

PR Reviewer Guidelines

  • Prefer pulling the branch and validating in the listed environment(s), not only reading code.
  • When approving, state why (tested in Dev, reviewed deployment notes, etc.).
  • For platform changes: verify solution/deploy steps are clear and complete.
  • For plugins: sanity-check registration details (Message, Stage, Filtering Attributes, Secure/Unsecure config).

… a new step. Edit requests need to happen back and forth between requester and admin without leaving a process step
@cheinrichs-oddball
cheinrichs-oddball requested a review from a team as a code owner August 4, 2026 18:22
@cheinrichs-oddball
cheinrichs-oddball requested review from WyattEmme-Oddball and removed request for a team August 4, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Activity Log governance plugin behavior so Edit Request activity logs can be created against the current process step (no forced transition), while preserving the existing server-side protection that blocks no-op step changes for the explicit “progress to next step” action.

Changes:

  • Updated ActivityLog_Create_ValidateActivityType to apply “current step” validation only to the Progress activity type (not Edit Request).
  • Updated plugin README to document the revised validation/UX behavior for Edit Requests vs. explicit step progression.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/README.md Documents that current-step validation is limited to explicit step-progression, and that Edit Requests may target the current step.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Create_ValidateActivityType.cs Removes Edit Request from the “no-op step change” validation so Edit Requests can be logged without forcing a step transition.
Suppressed comments (1)

apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/README.md:337

  • Same wording mismatch as earlier: this bullet says “Progress to step”, but the Activity Log type label in the app is “Progress to a New Step”. Updating the text keeps UX documentation consistent with what users/admins see.
- For explicit Progress to step actions, the Activity Log form disables selecting the current step to prevent no-op submissions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/README.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@WyattEmme-Oddball WyattEmme-Oddball left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cheinrichs-oddball
cheinrichs-oddball merged commit f1cd1a9 into main Aug 6, 2026
1 check passed
@cheinrichs-oddball
cheinrichs-oddball deleted the NOREF/Bug-Fix-Edit-Request-Is-Forced-To-Change-Steps branch August 6, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants