removing a requirement that Edit Requests have to move the request to… - #35
Merged
cheinrichs-oddball merged 2 commits intoAug 6, 2026
Merged
Conversation
… a new step. Edit requests need to happen back and forth between requester and admin without leaving a process step
cheinrichs-oddball
requested review from
WyattEmme-Oddball
and removed request for
a team
August 4, 2026 18:22
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Activity Log governance plugin behavior so Edit Request activity logs can be created against the current process step (no forced transition), while preserving the existing server-side protection that blocks no-op step changes for the explicit “progress to next step” action.
Changes:
- Updated
ActivityLog_Create_ValidateActivityTypeto apply “current step” validation only to the Progress activity type (not Edit Request). - Updated plugin README to document the revised validation/UX behavior for Edit Requests vs. explicit step progression.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/README.md | Documents that current-step validation is limited to explicit step-progression, and that Edit Requests may target the current step. |
| apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Create_ValidateActivityType.cs | Removes Edit Request from the “no-op step change” validation so Edit Requests can be logged without forcing a step transition. |
Suppressed comments (1)
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/README.md:337
- Same wording mismatch as earlier: this bullet says “Progress to step”, but the Activity Log type label in the app is “Progress to a New Step”. Updating the text keeps UX documentation consistent with what users/admins see.
- For explicit Progress to step actions, the Activity Log form disables selecting the current step to prevent no-op submissions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
WyattEmme-Oddball
approved these changes
Aug 5, 2026
WyattEmme-Oddball
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
cheinrichs-oddball
deleted the
NOREF/Bug-Fix-Edit-Request-Is-Forced-To-Change-Steps
branch
August 6, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… a new step. Edit requests need to happen back and forth between requester and admin without leaving a process step
PPE-80
Power Platform scope
App / Solution:
Environment(s) impacted:
Change type (check all that apply):
Description
Currently in the app, an Admin can't submit Edit Requests without changing the Process Step of the Request. This is not the desired behavior, so in this pull request, we've removed a limitation in the plugin that was forcing a step change for Edit Reqeuests. That rule enforcement should still exist on the "Progress to a new step" action.
What changed
Made a small change in the plugin code for Activity Logs.
Deployment notes
How to test this change
Verified in environment(s)
Risk / impact
PR Author Checklist
PR Reviewer Guidelines