Skip to content

add intersection of two AABB_tree#9501

Open
LeoValque wants to merge 44 commits into
CGAL:mainfrom
LeoValque:AABB-add_parallellization
Open

add intersection of two AABB_tree#9501
LeoValque wants to merge 44 commits into
CGAL:mainfrom
LeoValque:AABB-add_parallellization

Conversation

@LeoValque

@LeoValque LeoValque commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Add a parallellization of AABB_tree::build() (without any mutex) to improve running time.

Add PMP::AABB_self_intersections(), a variant of PMP::self_intersections() that used an AABB_tree instead of CGAL::box_intersection_d.

Todo

  • Add proper benchmark

Release Management

@LeoValque LeoValque changed the title add parallellization of AABB_tree::build and add variant of PMP::self_intersections using AABB_tree add variant of PMP::self_intersections using AABB_tree May 28, 2026
@sloriot sloriot added the depends on another PR This pull-request should only be merged after other ones. label May 29, 2026
@LeoValque

Copy link
Copy Markdown
Contributor Author

/build:v0

@github-actions

Copy link
Copy Markdown

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9501/v0/Manual/index.html

@LeoValque

Copy link
Copy Markdown
Contributor Author

/force-build:v0

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

There was an error while building the doc:

/home/runner/work/cgal/cgal/AABB_tree/doc/AABB_tree/aabb_tree.txt:314: warning: image file knot.png is not found in IMAGE_PATH: assuming external image.
/home/runner/work/cgal/cgal/AABB_tree/doc/AABB_tree/aabb_tree.txt:362: warning: image file iphigenia.png is not found in IMAGE_PATH: assuming external image.
/home/runner/work/cgal/cgal/AABB_tree/doc/AABB_tree/aabb_tree.txt:362: warning: image file nefertiti.png is not found in IMAGE_PATH: assuming external image.
/home/runner/work/cgal/cgal/AABB_tree/doc/AABB_tree/aabb_tree.txt:362: warning: image file twisted_knot.png is not found in IMAGE_PATH: assuming external image.

https://github.com/CGAL/cgal/actions/runs/28666735212

@LeoValque

Copy link
Copy Markdown
Contributor Author

/force-build:v0

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9501/v0/Manual/index.html

@LeoValque

Copy link
Copy Markdown
Contributor Author

/force-build:v0

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9501/v0/Manual/index.html

@afabri afabri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add a documented function in PMP?

Comment thread AABB_tree/benchmark/AABB_tree/CMakeLists.txt Outdated
Comment thread AABB_tree/benchmark/AABB_tree/tree_construction.cpp Outdated
Comment thread AABB_tree/benchmark/AABB_tree/tree_construction.cpp Outdated
Comment thread AABB_tree/benchmark/AABB_tree/tree_queries.cpp Outdated

bool do_intersect(const Query& query, const Node& node) const
{
#if 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up

Comment thread AABB_tree/include/CGAL/AABB_trees/intersection.h Outdated
Comment thread AABB_tree/include/CGAL/AABB_tree.h Outdated
@LeoValque

Copy link
Copy Markdown
Contributor Author

Do you plan to add a documented function in PMP?

Not in this PR

@LeoValque LeoValque changed the title add variant of PMP::self_intersections using AABB_tree add intersection of two AABB_tree Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends on another PR This pull-request should only be merged after other ones. Enhancement Speed Under Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants