Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/buskill_gui.py
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,7 @@ def build_config(self, config):
Config.read( self.bk.CONF_FILE )
Config.setdefaults('buskill', {
'buskill_trigger': 'lock-screen',
'persistent_log': 'False'
})

# TODO: don't hard-code this, pull it from kivy/config.py
Expand Down
5 changes: 3 additions & 2 deletions src/packages/buskill/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ def __init__(self):

# BusKill class was always initialised after finding the log file path Therefore in the new setup we are initialising it before the log file path is found
# This will prevent it from out of index error
self.LOG_FILE_PATH = logger.root.handlers[0].baseFilename if logger.root.handlers else None
handler = logger.root.handlers[0] if logger.root.handlers else None
self.LOG_FILE_PATH = getattr(handler, "baseFilename", None) if handler else None # Handle logging handlers without baseFilename
# Default value as False, because if no one updates the config.ini file then reverting back to old file path
self.PERSISTENT_LOG = False

Expand Down Expand Up @@ -427,7 +428,7 @@ def __init__(self):
# top to make UX *slightly* better for a user who wants to manually
# edit the config file. if we don't do this, then kivy will put it
# below its own settings, making the user scroll a lot to find them
contents = "[buskill]\n"
contents = "[buskill]\npersistent_log = False\n" # Updating the config option
with open( self.CONF_FILE, 'w' ) as fd:
fd.write( contents )

Expand Down
13 changes: 13 additions & 0 deletions src/packages/buskill/settings_buskill.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,19 @@
"confirmation": ["", "This selection may cause data loss! Are you sure you want to continue?\n\nThe 'soft-shutdown' trigger will immediately cause your computer to shutdown. This could cause you to lose work if, for example, you're writing an email or typing a text document.\n\nAre you sure you want to select the 'soft-shutdown' trigger, despite the risk of data loss?" ],
"options_icons": ["\ue1bf","\ue62a"]
},
{
"icon": "\ue873",
"type": "complex-options",
"title": "Persistent Logging",
"desc": "Do you want to store the log file persistently (keeping the data after your computer reboots)?",
"section": "buskill",
"key": "persistent_log",
"options": ["True","False"],
"options_human": ["True","False"],
"options_long": ["Log file will be not deleted after your system restarts","Log file will be deleted once you restart the computer"],
"confirmation": ["Please restart the app so the changes can be implimented","Please restart the app so the changes can be implimented"],
"options_icons": ["\ue161","\ue5cd"]
},
{
"type": "title",
"title": "Look & Feel"
Expand Down
Loading