globset: fix matches_all false positives#3427
Open
tmccombs wants to merge 1 commit into
Open
Conversation
Make sure that we correctly check that all globs are matched, even if multiple globs use the same strategy. Previously we only checked that all strategies matched, but didn't check with the strategies themselves. This now adds a `matches_all` method to each strategy to recursively check all globs. This is an alternative to BurntSushi#3302. It is a little more involved, but avoids allocating an array for tracking the number of matches. Fixes: BurntSushi#3290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that we correctly check that all globs are matched, even if multiple globs use the same strategy.
Previously we only checked that all strategies matched, but didn't check with the strategies themselves.
This now adds a
matches_allmethod to each strategy to recursively check all globs.This is an alternative to #3302. It is a little more involved, but avoids allocating an array for tracking the number of matches.
Fixes: #3290