feat: support RIPGREP_THREADS environment variable#3415
Open
leno23 wants to merge 3 commits into
Open
Conversation
Allow users to set a default thread count via RIPGREP_THREADS when --threads is not passed on the command line. CLI flags take precedence over the environment variable. Fixes BurntSushi#3317
leno23
force-pushed
the
feat/ripgrep-threads-env-3317
branch
from
15d8292 to
aa52d9f
Compare
Avoid an empty line in the long help text that caused `rg --help` to panic when stripping roff markup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RIPGREP_THREADSto set a default thread count when-j/--threadsis not passed0in the environment variable keeps the existing heuristic default--threadson the command line takes precedence and ignores invalid env values--threadsflag help textFixes #3317
Test plan
cargo test -p ripgrep f3317cargo test -p ripgrep test_threads