Feat: Add --hierarchy flag for showing parent context lines#3413
Open
yash3605 wants to merge 4 commits into
Open
Feat: Add --hierarchy flag for showing parent context lines#3413yash3605 wants to merge 4 commits into
yash3605 wants to merge 4 commits into
Conversation
Author
|
This last ci/test error is due to Github Actions Infrastructure. I have fixed most issues in ci. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Feature suggested in Issue: #3395.
I was able to do it using a simple Stack. what I did was that - when we're reading file, we check the indentation of each line. if the indentation of current line is less than the previous ones then we Pop them from the stack otherwise we push. and when I match is found the Stack is printed as it is.
what I couldn't do was implementing the Stack thing via StandardSink or Sink. because the code base is modular and tightly coupled and I was facing some ownership issues when borrowing StandardSink and others. So I had to create the stack separately and then pass it forward by some workarounds like creating a SinkWrapper for Sink and then Pass the Map I have made for the output.
Same with Printing the final result. I could have used WriteColor trait but I was facing same Ownership issues and I couldn't borrow another mutable reference so here I went with plain Println!() statement.
Before Hierarchy:

After Hierarchy (in Debug mode):

After Hierarchy (in build/release):
