Fix line numbers for adjacent multiline replacements#3412
Open
puneetdixit200 wants to merge 1 commit into
Open
Fix line numbers for adjacent multiline replacements#3412puneetdixit200 wants to merge 1 commit into
puneetdixit200 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2779.\n\nSummary:\n- Preserve original bytes for replaced printer output so replacement matches can map back to original line numbers.\n- Use original match line numbers for replacement output, while preserving normal line-count behavior for non-replacement multiline output.\n- Add a regression test for adjacent multiline replacements that collapse to one output line each.\n\nTests:\n- cargo test --all