OpenScenarioXML Export#421
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (17.56%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 89.85% 87.97% -1.89%
==========================================
Files 48 48
Lines 13346 13419 +73
==========================================
- Hits 11992 11805 -187
- Misses 1354 1614 +260
🚀 New features to boost your workflow:
|
|
An example scenario of a pedestrian crossing the road, occluded by a car, simulated in Metadrive and then exported to XOSC and replayed in ESMINI. ESMINI Replay MP4: |
| ) | ||
| xosc_obj = xosc.Pedestrian( | ||
| name=obj_name, | ||
| mass=obj.mass, |
There was a problem hiding this comment.
Is mass required for pedestrians but not for cars?
There was a problem hiding this comment.
Surprisingly, yes:
- Pedestrian: https://github.com/pyoscx/scenariogeneration/blob/debb300ec25c14cf16aae390f399a7311bd209f1/scenariogeneration/xosc/entities.py#L435
- Vehicles: https://github.com/pyoscx/scenariogeneration/blob/debb300ec25c14cf16aae390f399a7311bd209f1/scenariogeneration/xosc/entities.py#L863
And this appears supported by the spec. No idea why though.
dfremont
left a comment
There was a problem hiding this comment.
Looks good overall, just one issue (how to handle/ban dynamically spawned objects) and a bunch of minor comments above.

Description
Added experimental functionality to export the result of a Scenic simulation to OpenScenarioXML.
Issue Link
#334 #32
Checklist
pytestand/or other meansAdditional Notes
N/A