Skip to content

fix(chatui): command tooltip auto-closes with panel & enhances dark mode visibility#8606

Open
elecvoid243 wants to merge 13 commits into
AstrBotDevs:masterfrom
elecvoid243:cmd_suggestion
Open

fix(chatui): command tooltip auto-closes with panel & enhances dark mode visibility#8606
elecvoid243 wants to merge 13 commits into
AstrBotDevs:masterfrom
elecvoid243:cmd_suggestion

Conversation

@elecvoid243
Copy link
Copy Markdown
Contributor

@elecvoid243 elecvoid243 commented Jun 5, 2026

Modifications / 改动点

修复命令提示气泡在候选框关闭后仍然驻留的问题,并让暗色模式下的指令描述字体更醒目

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

123

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Fix chat command suggestion tooltip behavior and improve dark mode readability.

Bug Fixes:

  • Ensure the command suggestion tooltip closes automatically when the suggestion panel becomes hidden.

Enhancements:

  • Increase the brightness of command descriptions in dark mode to improve legibility.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CommandSuggestion.vue component to hide the tooltip when the suggestion panel is closed and improves the readability of command descriptions in dark mode by adjusting their text color. A review comment suggests extending the watcher to also monitor changes in the commands list, which prevents "ghost" tooltips from remaining visible when items are dynamically filtered out of the DOM.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashboard/src/components/chat/CommandSuggestion.vue
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The watch on props.visible directly mutates tooltip.visible, introducing two sources of truth for visibility; consider deriving tooltip.visible from props.visible (or a single reactive state) to avoid potential inconsistencies.
  • The updated dark-mode color #e0e0e0 is hard-coded; if you have a design token or CSS variable system for theming, it would be more maintainable to reference that instead of a literal color value.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `watch` on `props.visible` directly mutates `tooltip.visible`, introducing two sources of truth for visibility; consider deriving `tooltip.visible` from `props.visible` (or a single reactive state) to avoid potential inconsistencies.
- The updated dark-mode color `#e0e0e0` is hard-coded; if you have a design token or CSS variable system for theming, it would be more maintainable to reference that instead of a literal color value.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants