Skip to content

fix: translateIfKey breaks plugin config labels by treating plain text as i18n keys #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DDomelette wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: translateIfKey breaks plugin config labels by treating plain text as i18n keys #8564

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49fdf5e
fix: translateIfKey broke plugin config labels by treating plain text…
Jun 3, 2026
00c0484
fix: return original value instead of null for non-i18n key strings c…
DDomelette Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dashboard/src/composables/useConfigTextResolver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ export function useConfigTextResolver(props = {}) {

const translateIfKey = (value) => {
if (!value || typeof value !== 'string') return value
return getRaw(value) ? tm(value) : value
if (!value.includes('.')) return value
return getRaw(value) ? tm(value) : null
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

If value is a plain text string that contains a dot (for example, version numbers like "v1.0", IP addresses like "127.0.0.1", or descriptions containing sentences with periods like "Timeout (e.g. 5s)"), !value.includes('.') will evaluate to false.

Since it is not a valid i18n key, getRaw(value) will return null, causing translateIfKey to return null. This will result in fallbackText becoming '' (empty string) in resolveConfigText, making these plain text labels, descriptions, or hints completely disappear from the UI.

To prevent this regression, we should return the original value as a fallback when getRaw(value) is falsy, rather than returning null.

Suggested change
return getRaw(value) ? tm(value) : null
return getRaw(value) ? tm(value) : value

}

const hasPluginI18n = () => {
Expand Down