feat: refresh card based on IDLE or STREAMING state changes#622
feat: refresh card based on IDLE or STREAMING state changes#622fuatakgun wants to merge 6 commits into
Conversation
|
I get the idea what you want to fix. But I don't like the solution. It can have a lot of side effects. |
|
Understood, any suggestion? |
|
Maybe easiest way to change reconnect timeout via card config for this cameras. Such a thing is not difficult to implement |
|
Works for me, but would it go back to rendering the poster when the stream stops? |
|
I don't know. Haven't tested this case. Maybe something should be fixed for this |
|
Hi, what's the status of this PR? Would be great if this feature can be incorporated. |
|
Is this functionality already implemented through a separate PR and this PR can be closed? |
|
Hey @fuatakgun is this something that could possibly be fixed either on the eufy addon side or the eufy integration side? @AlexxIT 's concern is valid because all other camera brands work fine, but the Eufy ones suck. |
There are some cameras out there which are only streaming intermittently, rather than continuously so WebRTC custom card waits for next reconnect (0 to 30 seconds).
With this PR, webrtc will be forced to refresh itself if the underlying camera entity's state changes into IDLE or STREAMING.
IDLE and STREAMING are defined in home assistant camera entity.
https://github.com/home-assistant/core/blob/dev/homeassistant/components/camera/__init__.py#L96
Looking forward to hearing your feedback.