fix: prevent AttributeError when optional fields are None in web_search/file_search tools

[Oxygen56]

Description

Fixes #1285

When using the OpenAI Agents SDK with file search or web search tools, on_span_end raises:

AttributeError: 'NoneType' object has no attribute '__dict__'

Root Cause

In get_response_tool_web_search_attributes and get_response_tool_file_search_attributes, hasattr() guards check for the presence of optional fields (user_location, filters, ranking_options), but hasattr() returns True even when the attribute value is None. Accessing .__dict__ on None then raises AttributeError.

Fix

Added and <attr> is not None checks alongside each hasattr() guard:

• get_response_tool_web_search_attributes: tool.user_location
• get_response_tool_file_search_attributes: tool.filters, tool.ranking_options

Testing

Added two new test cases verifying that web search and file search tools work correctly when optional fields are None. All 15 tests pass.

• test_get_response_tool_web_search_attributes_with_none_user_location
• test_get_response_tool_file_search_attributes_with_none_filters_and_ranking

[biswajeetdev]

Clean fix — the AttributeError happens because the OpenAI SDK marks user_location, filters, and ranking_options as optional in the type stubs, but the instrumentation code was accessing them unconditionally.

One thing to double-check on the web_search side: the fix uses hasattr(tool, "search_context_size") to guard the access. On Pydantic models and SDK dataclasses, hasattr always returns True for declared fields (the attribute exists, it is just None). So the actual guard needed is if tool.search_context_size is not None — which the code likely already has elsewhere. Worth a quick scan to make sure hasattr is not being used as a None check anywhere in this diff, since on Pydantic models it will always pass.

Tests cover the key cases (None values for optional fields, missing fields) and assert the function does not raise — good regression anchors.

[Oxygen56]

Thanks for the careful check. I updated the PR so hasattr(...) is only used to tolerate older object shapes; optional values are now written into tool arguments only when the value is not None.

Concretely, this now covers search_context_size, user_location, vector_store_ids, filters, max_num_results, and ranking_options.

Validation run locally:

• git diff --check
• uv run -m pytest tests/unit/instrumentation/openai_core/test_response_attributes.py -k "web_search or file_search or search_attributes" -q -> 5 passed, 11 deselected