Skip to content

Remove b37 dna#95

Open
Istaisa wants to merge 3 commits into
developmentfrom
remove_b37_dna
Open

Remove b37 dna#95
Istaisa wants to merge 3 commits into
developmentfrom
remove_b37_dna

Conversation

@Istaisa

@Istaisa Istaisa commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Removes all of the b37 DNA specific code from scripts to simplify with LIMS and transition towards retiring this pipeline.

To test:

  • Run a mixed RNA/DNA run from this pipeline, check that it runs correctly and produces the same results as previously.

@Istaisa Istaisa requested a review from SamAnderson27 April 14, 2026 08:59
@SamAnderson27

SamAnderson27 commented Apr 15, 2026

Copy link
Copy Markdown

I'm happy with these changes, they all make sense.

I've rerun the processing on a newish run using LIMS numbers etc and it seems to have the same output as the original run. Could you please run your comparison script on it to see any differences between the folders?

Here is the file path for the new run:
/data/output/validations/TSO500/260410_A01771_0806_BHH3TKDRX7/TSO500

@Istaisa

Istaisa commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Unfortunately don't have a good comparison script for this especially with the low level calls and stuff. I'd either do some intersects on the filtered vcfs or just upload the new run to SVD staging and compare the variants that get pulled through

@SamAnderson27 SamAnderson27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked around 10 samples on the run with their live counterparts and they match up on variants called (a few reads different here and there due to the nature of the pipeline).
Happy for this to be merged into dev when you want 🎆

@Istaisa

Istaisa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@erikwaskiewicz not sure how this affects the TSO cloud updates but this should be good to go if it doesn't clash with anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants