Skip to content

Update to use OIDC Keys #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacquelynsmale wants to merge 6 commits into from
Closed

Update to use OIDC Keys #3131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31f9c84
update github actions with role arn var
jacquelynsmale Jun 17, 2026
163d865
update aws params
jacquelynsmale Jun 17, 2026
7194eae
update custom keys
jacquelynsmale Jun 17, 2026
102e8bc
update test with role_arn
jacquelynsmale Jun 17, 2026
89829b0
note to update readme
jacquelynsmale Jun 17, 2026
56c1fe9
add line to cfg
jacquelynsmale Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/deploy-custom-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,8 @@ jobs:

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.V2_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.V2_AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.V2_AWS_SESSION_TOKEN }}
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.AWS_ROLE_ARN }}

@williamh890 williamh890 Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be

Suggested change
aws-role-arn: ${{ secrets.AWS_ROLE_ARN }}
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}


- uses: actions/setup-python@v6
with:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/deploy-custom-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,8 @@ jobs:

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.V2_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.V2_AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.V2_AWS_SESSION_TOKEN }}
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.AWS_ROLE_ARN }}

- uses: actions/setup-python@v6
with:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/deploy-daac-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,8 @@ jobs:

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.V2_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.V2_AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.V2_AWS_SESSION_TOKEN }}
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.AWS_ROLE_ARN }}

- uses: actions/setup-python@v6
with:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/deploy-daac-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,8 @@ jobs:

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.V2_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.V2_AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.V2_AWS_SESSION_TOKEN }}
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.V2_AWS_ROLE_ARN }}

- uses: actions/setup-python@v6
with:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/deploy-edc-sandbox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@ jobs:

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.V2_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.V2_AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.V2_AWS_SESSION_TOKEN }}
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.AWS_ROLE_ARN }}

- uses: actions/setup-python@v6
with:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/deploy-plus-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,8 @@ jobs:

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.V2_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.V2_AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.V2_AWS_SESSION_TOKEN }}
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.AWS_ROLE_ARN }}

- uses: actions/setup-python@v6
with:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/deploy-plus-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,8 @@ jobs:

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.V2_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.V2_AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.V2_AWS_SESSION_TOKEN }}
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.AWS_ROLE_ARN }}

- uses: actions/setup-python@v6
with:
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ aws --profile <profile> cloudformation deploy \
Once the `github-actions` IAM user has been created, you can create an AWS access key for that user,
which we will use to deploy HyP3 via CI/CD tooling:

## TODO UPDATE WITH OIDC STEPS
1. Go to AWS console -> IAM -> Users -> github-actions -> security credentials tab -> "create access key".
2. Select "Other" for key usage
3. (Optional) Add tag value to describe the key, such as "For GitHub Actions CI/CD pipelines"
Expand Down
5 changes: 1 addition & 4 deletions tests/cfg.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,5 @@ DEFAULT_CREDITS_PER_USER=25
DEFAULT_APPLICATION_STATUS=NOT_STARTED
SYSTEM_AVAILABLE=true
AWS_DEFAULT_REGION=us-west-2
AWS_ACCESS_KEY_ID=testing
AWS_SECRET_ACCESS_KEY=testing
AWS_SECURITY_TOKEN=testing
AWS_SESSION_TOKEN=testing
AWS_ROLE_ARN=testing
CONTENT_BUCKET=test-bucket
Loading