fix: ship examples README in wheel#228
Conversation
|
Hey @w3lld1 thanks for picking this up, but this issue has been already assigned to @riticap1318, so I would wait for him to submit his PR, or you can work together on it if he agrees. Other than that, happy to review shall riticap1318 widthraw his interest or struggle with the fix. In the meantime you can check for other open issues and try to claim them by commenting on issues before opening a PR. PRs without being claimed will only be considered if patching security issues or hotfixes that bear urgent priority labels. |
|
Thanks for flagging this, and sorry for missing that the issue was already assigned. I'll close this PR to avoid stepping on the existing contributor's work. Happy to reopen or collaborate if it becomes useful later. |
|
Closing to avoid duplicating work on an issue already assigned to another contributor. |
Summary
Fixes #226 (Phase A): ship the examples index with the wheel so
skillware examplesandskillware list --examplescan work for pip-only installs without relying on GitHub raw access.Changes
skillware/examples/README.mdas the packaged copy of the examples index.skillwarepackage data inpyproject.toml._examples_readme_path()to check the installed package copy before checkout/cwd discovery and GitHub fallback.Verification
pytest tests/test_cli.py -q43 passed in 0.42spython -m build --wheelskillware/examples/README.md./tmpand verified_load_examples_index()loads the installed packaged copy with 30 rows.Notes
This keeps the existing GitHub raw fallback for old wheels, editable/dev layouts, and other edge cases.