Aggregate total_failed_with_waiver inline with other summary fields - #443
Closed
Ashishsharma1903 wants to merge 1 commit into
Closed
Aggregate total_failed_with_waiver inline with other summary fields#443Ashishsharma1903 wants to merge 1 commit into
Ashishsharma1903 wants to merge 1 commit into
Conversation
- Updated recomputation logic in `json_to_html.py` to correctly extract and display `FAILED with WAIVER` test results separately from regular `FAILED`. - Adjusted bar chart and HTML table to reflect waived failures using dedicated color and class. - Ensured consistency between recomputed suite summary and visual HTML output. Signed-off-by: Ashish Sharma <ashish.sharma2@arm.com>
chetan-rathore
left a comment
chetan-rathore
left a comment
Contributor
There was a problem hiding this comment.
Total test count for BSA is not including waived tests.
chetan-rathore
requested changes
Aug 16, 2025
chetan-rathore
left a comment
chetan-rathore
left a comment
Contributor
There was a problem hiding this comment.
Also BSA results in merged json must have waiver count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Aggregate total_failed_with_waiver inline with other summary fields
Signed-off-by: Ashish Sharma ashish.sharma2@arm.com