Exclude the datamodel.h header from being added to ROOT dictionaries#974
Merged
Conversation
1 task
It seems to cause some issues when it is embedded in the dictionary but because of include guards, the classes it's looking for (Links type aliases) are not defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Fix key4hep/EDM4hep#496
It seems to cause some issues when it is embedded in the dictionary but because of include guards, the classes it's looking for (Links type aliases) are not defined. I know this because one way to fixing key4hep/EDM4hep#496 is removing all the include guards in
LinkCollection.h. I think there is no reason fordatamodel.hto be in the ROOT dictionaries, so this is a good idea regardless.