-
Notifications
You must be signed in to change notification settings - Fork 4
Refactor GitHub service to effect #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Peu77
wants to merge
48
commits into
dev
Choose a base branch
from
refactor-github-service-to-effect
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 32 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a662b79
Merge pull request #528 from 42core-team/dev
PaulicStudios f28d926
Merge pull request #534 from 42core-team/dev
PaulicStudios 507ece0
Merge pull request #580 from 42core-team/dev
Peu77 a6e5af0
refactor: update documentation for GitHub service to reflect transiti…
Peu77 3dc279e
remove old nestjs github-service project
Peu77 e7334eb
feat: add configuration for GitHub service using Effect
Peu77 09e5eac
feat: implement RabbitMQ service using Effect
Peu77 df701d9
feat: add decryption utility using Effect and CryptoJS
Peu77 54aa375
update dockerfile in github-service to use bun
Peu77 24ff82e
implement GitHub client with API methods and error handling using effect
Peu77 4ba6f00
implement main application layer with GitHub and RabbitMQ integration…
Peu77 41052c0
add message schemas and handlers for GitHub repository operations
Peu77 e20011d
refactor: update package.json scripts and dependencies for Bun integr…
Peu77 8ba8aa5
add: create bun.lock file for dependency management and workspace con…
Peu77 a538a2f
Merge remote-tracking branch 'origin/dev' into refactor-github-servic…
Peu77 bca6231
refactor: streamline InfraLayer and update message consumption logic
Peu77 294e235
integrate @effect/eslint-plugin for enhanced linting support
Peu77 2f912ba
add unit tests for RepoUtilsService methods
Peu77 2a93ffd
refactor: update test paths and script commands in package.json and t…
Peu77 1a242b8
refactor: improve error logging in message consumption logic
Peu77 e4d0ee3
remove bad comments
Peu77 7ddc7b9
improve code formatting and structure in GitHub client
Peu77 eaff58d
format code
Peu77 3b9ceb9
remove unnecessary cast
Peu77 50d6169
refactor: enhance logging attributes in pushToTeamRepo function
Peu77 5130eb7
format
Peu77 99b1aa1
refactor: improve error handling in decryptSecret function
Peu77 cde89fe
replace catchAll with tapError for improved error handling
Peu77 f2d3faf
fix: prevent double execution of eff in withRetries after rate-limit …
Copilot 8bb57c4
refactor: update lint command and improve error handling in program.ts
Peu77 e6efc42
Merge remote-tracking branch 'origin/refactor-github-service-to-effec…
Peu77 a0693c0
refactor: update lint command and improve error handling in program.ts
Peu77 531275b
implement retry logic for message sending in RabbitMQ consumer
Peu77 a5cab58
use replaceAll for path normalization in repoUtils
Peu77 7177712
refactor: simplify user addition to repository logic in handleAddUser…
Peu77 6e2583e
enhance RabbitMQ connection and channel management with improved erro…
Peu77 1688462
integrate OpenTelemetry for metrics and tracing in GitHub service
Peu77 220f94a
add observability configuration for GitHub service with Prometheus, T…
Peu77 6621314
Merge pull request #616 from 42core-team/dev
PaulicStudios 72c6195
Merge pull request #620 from 42core-team/dev
PaulicStudios 98f2803
Merge pull request #622 from 42core-team/dev
PaulicStudios 136b3bb
Merge pull request #641 from 42core-team/dev
PaulicStudios a0f9dfb
remove devcontainer
Peu77 3a18565
migrate GitHub Service workflows and pre-commit hooks from pnpm to Bun
Peu77 17fbb51
Merge branch 'main' into refactor-github-service-to-effect
Peu77 8e24e3a
add dynamic image tagging to GitHub workflows and extend summary with…
Peu77 0a8e60d
fix type error
Peu77 f3b2b47
update dependencies: bump NestJS, TypeORM, Jest, and other packages i…
Peu77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,30 @@ | ||
| ## Stage 1: Build | ||
| FROM node:25-alpine AS builder | ||
| FROM oven/bun:1.3.11-alpine AS builder | ||
| WORKDIR /app | ||
|
|
||
| # Install dependencies | ||
| COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./ | ||
| RUN npm install -g pnpm && pnpm install --frozen-lockfile | ||
| COPY package.json bun.lock ./ | ||
| RUN bun install --frozen-lockfile | ||
|
|
||
| # Copy source and build | ||
| COPY . . | ||
| RUN pnpm run build | ||
|
|
||
| # Prune dev dependencies to keep only production deps | ||
| RUN pnpm prune --prod | ||
| RUN bun run build | ||
|
|
||
| ## Stage 2: Production runtime | ||
| FROM node:25-alpine AS runner | ||
| FROM oven/bun:1.3.11-alpine AS runner | ||
| WORKDIR /app | ||
| ENV NODE_ENV=production | ||
|
|
||
| # Copy production dependencies and built artifacts | ||
| COPY package.json ./ | ||
| COPY --from=builder /app/node_modules ./node_modules | ||
| COPY package.json bun.lock ./ | ||
| RUN bun install --frozen-lockfile --production | ||
| COPY --from=builder /app/dist ./dist | ||
|
|
||
| RUN apk update | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. apk update could still be needed, needs to be tested
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tested it |
||
| RUN apk add --no-cache git | ||
|
|
||
| # Set git config for container | ||
| RUN git config --global user.name "corethegame" | ||
| RUN git config --global user.email "core@paulgrossmann.de" | ||
|
|
||
| # Start the microservice | ||
| CMD ["node", "dist/main.js"] | ||
| CMD ["bun", "dist/main.js"] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be no need to install the dependencies here again as this was already done in step one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is, here I only need the runtime depedencies and in the step before it also installs the dev depedencies