Skip to content

fix: extension popup panel height on fractional scaling #13607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shelldandy wants to merge 4 commits into
base: dev
Choose a base branch
from
+13 −0
Open

fix: extension popup panel height on fractional scaling #13607

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85cc23d
gh-13518: Fix oversized extension popup panel on Wayland
shelldandy May 7, 2026
a27cf7c
fix: update lastCalculatedInViewHeight in fixedWidth=false branch
shelldandy May 7, 2026
46d1ed9
fix: regenerate extension popup patch via surfer export
shelldandy May 14, 2026
a851b1b
fix: use Math.max to mirror fixedWidth=true branch
shelldandy May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/browser/components/extensions/ExtensionPopups-sys-mjs.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/browser/components/extensions/ExtensionPopups.sys.mjs b/browser/components/extensions/ExtensionPopups.sys.mjs
index 1cd35175507bd442aae6857e65015cfed00058e3..c7f9c5a4de05cfa476b89137798061ce36ef2f40 100644
--- a/browser/components/extensions/ExtensionPopups.sys.mjs
+++ b/browser/components/extensions/ExtensionPopups.sys.mjs
@@ -418,6 +418,8 @@ export class BasePopup {
this.browser.style.minWidth = `${width}px`;
this.browser.style.height = `${height}px`;
this.browser.style.minHeight = `${height}px`;
+
+ this.lastCalculatedInViewHeight = Math.max(height, this.viewHeight);
}

let event = new this.window.CustomEvent("WebExtPopupResized", { detail });