From 1d379cccb5d90a915e3bb18da2c475329f42ef89 Mon Sep 17 00:00:00 2001 From: Jack-sh1 Date: Thu, 23 Apr 2026 17:26:19 +0800 Subject: [PATCH 1/2] fix: correct typos in runtime source code - Fix "unkown" -> "unknown" in streaming error message - Fix "preResovled" -> "preResolved" in comment - Fix "createRemixReuqest" -> "createRemixRequest" function name --- .../src/core/server/stream/createReadableStream.ts | 2 +- .../runtime/plugin-runtime/src/router/runtime/constants.ts | 2 +- .../runtime/plugin-runtime/src/router/runtime/plugin.node.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/runtime/plugin-runtime/src/core/server/stream/createReadableStream.ts b/packages/runtime/plugin-runtime/src/core/server/stream/createReadableStream.ts index 7f407714aeef..16292c92a527 100644 --- a/packages/runtime/plugin-runtime/src/core/server/stream/createReadableStream.ts +++ b/packages/runtime/plugin-runtime/src/core/server/stream/createReadableStream.ts @@ -130,7 +130,7 @@ export const createReadableStreamFromElement: CreateReadableStreamFromElement = callback(e); } else { callback( - new Error('Received unkown error when streaming'), + new Error('Received unknown error when streaming'), ); } } diff --git a/packages/runtime/plugin-runtime/src/router/runtime/constants.ts b/packages/runtime/plugin-runtime/src/router/runtime/constants.ts index 16b96cc8167f..82282bd687fb 100644 --- a/packages/runtime/plugin-runtime/src/router/runtime/constants.ts +++ b/packages/runtime/plugin-runtime/src/router/runtime/constants.ts @@ -34,7 +34,7 @@ export const resolveFnStr = `function r(e,r,o,A){A?_ROUTER_DATA.r[e][r].reject(A /** * update data for pre resolved promises * original function: - * function preResovledDeferredPromise(data, error) { + * function preResolvedDeferredPromise(data, error) { if(typeof error !== 'undefined'){ return Promise.reject(new Error(error.message)); }else{ diff --git a/packages/runtime/plugin-runtime/src/router/runtime/plugin.node.tsx b/packages/runtime/plugin-runtime/src/router/runtime/plugin.node.tsx index ee70bfcce7bf..819f2432ac63 100644 --- a/packages/runtime/plugin-runtime/src/router/runtime/plugin.node.tsx +++ b/packages/runtime/plugin-runtime/src/router/runtime/plugin.node.tsx @@ -40,7 +40,7 @@ import { import type { RouterConfig } from './types'; import { createRouteObjectsFromConfig, renderRoutes, urlJoin } from './utils'; -function createRemixReuqest(request: Request) { +function createRemixRequest(request: Request) { const method = 'GET'; const { headers } = request; const controller = new AbortController(); @@ -136,7 +136,7 @@ export const routerPlugin = ( // We can't pass post request to query,due to post request would trigger react-router submit action. // But user maybe do not define action for page. - const remixRequest = createRemixReuqest( + const remixRequest = createRemixRequest( context.ssrContext!.request.raw, ); From 8a994811bde0bc75c2fd659e6a1695554aab05e2 Mon Sep 17 00:00:00 2001 From: Jack-sh1 Date: Thu, 23 Apr 2026 18:21:38 +0800 Subject: [PATCH 2/2] fix(create): add @rsbuild/core/types reference to project template The generated modern-app-env.d.ts is missing the @rsbuild/core/types reference, causing TypeScript errors for import.meta.env.DEV and other Rsbuild built-in environment variables. Closes #8522 --- packages/toolkit/create/template/src/modern-app-env.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/toolkit/create/template/src/modern-app-env.d.ts b/packages/toolkit/create/template/src/modern-app-env.d.ts index 1e851dcf7213..f05cc383c59f 100644 --- a/packages/toolkit/create/template/src/modern-app-env.d.ts +++ b/packages/toolkit/create/template/src/modern-app-env.d.ts @@ -1 +1,2 @@ /// +///