Merge pull request #18 from valory-xyz/feat/modern-go-bump

chore: Bump to Go 1.24 and libp2p v0.33

Author: DavidMinarsch

.github/workflows/workflow.yml

@@ -16,21 +16,20 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@master
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
         with:
-          go-version: "1.17.7"
+          go-version: "1.24.0"
       - name: Install dependencies (ubuntu-latest)
         run: |
           sudo apt-get update --fix-missing
           sudo apt-get autoremove
           sudo apt-get autoclean
       - name: Golang code style check (libp2p_node)
-        uses: golangci/golangci-lint-action@v3.1.0
-        env:
-          ACTIONS_ALLOW_UNSECURE_COMMANDS: true
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.45.2
+          version: v1.64.5
+          args: --timeout=5m
           working-directory: ./
 
   golang_checks:
@@ -41,37 +40,27 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        python-version: [3.6]
     timeout-minutes: 45
     steps:
-    - uses: actions/checkout@master
-    - uses: actions/setup-go@v3
+    - uses: actions/checkout@v4
+    - uses: actions/setup-go@v5
       with:
-        go-version: "1.17.7"
-    - if: matrix.os == 'macos-latest'
-      working-directory: .
-      run: |
-         export LINKPATH=`go env GOTOOLDIR`/link
-         echo $LINKPATH
-         sudo cp $LINKPATH ${LINKPATH}_orig
-         sudo cp link $LINKPATH
-         sudo chmod a+x $LINKPATH
-    - if: matrix.python-version == '3.6'
-      name: Golang unit tests (libp2p_node)
+        go-version: "1.24.0"
+    - name: Golang unit tests (libp2p_node)
       working-directory: ./
       run: make test
 
   libp2p_coverage:
     name: libp2p_coverage
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.17.7
-        uses: actions/setup-go@v1
+      - name: Set up Go 1.24.0
+        uses: actions/setup-go@v5
         with:
-          go-version: "1.17.7"
+          go-version: "1.24.0"
         id: go
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v1
+        uses: actions/checkout@v4
       - name: Install dependencies (ubuntu-latest)
         run: |
           sudo apt-get update --fix-missing

CLAUDE.md

@@ -0,0 +1,56 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Overview
+
+This repo is `libp2p_node`, the Go implementation of a node for the Agent Communication Network (ACN). ACN lets agents (see `open-aea`) discover each other and exchange messages addressed solely by wallet address. The binary is a single entry point (`libp2p_node.go`, `package main`, module `libp2p_node`) that wires together the AEA-side pipe and the libp2p-based DHT.
+
+## Common commands
+
+```bash
+make build       # go build
+make test        # full test suite with coverage (serial: -p 1, no inlining, no test cache)
+make race_test   # same, with -race
+make lint        # golines . -w && golangci-lint run
+make install     # go get -v -t -d ./...
+make clean       # remove binary + coverage.txt
+```
+
+Run a single test:
+```bash
+go test -gcflags=-l -count=1 -v ./dht/dhtpeer -run TestRoutingAllToAllConnectClientsSamePeer
+```
+`-gcflags=-l` disables inlining (required by `bou.ke/monkey`), and `-p 1` in `make test` forces serial package execution because tests bind fixed ports — keep those flags when running tests that touch networking.
+
+`run_acn_node_standalone.py` launches the built binary standalone (outside an AEA), reading env-file config; `--config-from-env` on the binary reads config from environment variables instead of an AEA pipe. See README for bootstrap/entry node env-file examples.
+
+## Architecture
+
+The node can run in one of two modes, selected in `libp2p_node.go:main` by whether a public URI is set:
+
+- **Peer mode** (`dht/dhtpeer`) — full libp2p host. Runs the DHT, optionally a relay service, a delegate service (TCP endpoint for `p2p_libp2p_client` connections), an optional mailbox service, and optional Prometheus monitoring. Constructed via functional options (`dht/dhtpeer/options.go`).
+- **Client mode** (`dht/dhtclient`) — lightweight, bootstraps from entry peers, no public address. Used when `AEA_P2P_URI_PUBLIC` is unset.
+
+Both modes implement the `dhtnode.DHTNode` interface (`dht/dhtnode/dhtnode.go`): `RouteEnvelope`, `ProcessEnvelope`, `MultiAddr`, `PeerID`, `Close`. `main` connects the AEA pipe to the node by (a) forwarding envelopes from `agent.Queue()` into `node.RouteEnvelope`, and (b) registering `agent.Put` as the node's inbound envelope handler.
+
+Key packages:
+
+- `aea/` — the AEA-facing API. `api.go` handles config (env or pipe-based), `envelope.proto`/`envelope.pb.go` is the wire format, `pipe.go` is the Unix-pipe transport to a co-located Python AEA.
+- `dht/dhtnode/` — shared stream protocol handlers and the `DHTNode` interface. The ACN libp2p protocol IDs (`/aea/0.1.0`, `/aea-address/0.1.0`, `/aea-register/0.1.0`) are defined here.
+- `dht/dhtpeer/` — peer implementation; `mailbox.go` is the store-and-forward mailbox service, `notifee.go` hooks libp2p connection events, `benchmarks_test.go` contains throughput benchmarks.
+- `dht/dhtclient/` — client implementation.
+- `dht/dhttests/` — shared test fixtures/harness (imported by other `dht/*` tests).
+- `dht/common/`, `dht/monitoring/` — shared helpers and the Prometheus monitoring abstraction.
+- `acn/`, `protocols/`, `utils/`, `common/` — ACN-level helpers, generated protocol messages, logging and crypto utilities.
+- `mocks/` — gomock-generated mocks (see https://github.com/golang/mock for regeneration).
+
+### Messaging patterns
+
+ACN supports several delivery paths between an AEA `Connection` and a `Peer`, via optional `Delegate Client` and `Relay Peer` hops — see README.md "Messaging patterns" for the full matrix. ACN must guarantee total ordering of messages between any pair of agents regardless of which path is used.
+
+## Go / tooling notes
+
+- Go module: `libp2p_node` (go 1.17). Internal imports use the module path, e.g. `libp2p_node/dht/dhtpeer`.
+- Dependencies are pinned to older libp2p (`go-libp2p v0.8.3`, `go-libp2p-core v0.5.3`, `go-libp2p-kad-dht v0.7.11`) — do not casually bump these; the DHT protocol and stream APIs differ substantially in newer versions.
+- `golines` reformats long lines as part of `make lint`; run it before committing Go changes.

aea/api.go

@@ -136,7 +136,7 @@ func (aea AeaApi) RecordStoragePath() string {
 func (aea AeaApi) Put(envelope *Envelope) error {
 	if aea.standalone {
 		errorMsg := "node running in standalone mode"
-		logger.Warn().Msgf(errorMsg)
+		logger.Warn().Msg(errorMsg)
 		return errors.New(errorMsg)
 	}
 	aea.send_queue <- envelope
@@ -146,7 +146,7 @@ func (aea AeaApi) Put(envelope *Envelope) error {
 func (aea *AeaApi) Get() *Envelope {
 	if aea.standalone {
 		errorMsg := "node running in standalone mode"
-		logger.Warn().Msgf(errorMsg)
+		logger.Warn().Msg(errorMsg)
 		return nil
 	}
 	return <-aea.out_queue

dht/common/handlers.go

@@ -28,7 +28,7 @@ import (
 
 	"log"
 
-	"github.com/libp2p/go-libp2p-core/network"
+	"github.com/libp2p/go-libp2p/core/network"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog"
 	"google.golang.org/protobuf/proto"