ls: apply two-line --time-style format to old/recent files correctly - #12681
Open
sylvestre wants to merge 1 commit into
Open
ls: apply two-line --time-style format to old/recent files correctly#12681sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
sylvestre
force-pushed
the
ls-time-style-recent-old
branch
from
June 7, 2026 19:54
d3c2084 to
3be1309
Compare
Contributor
|
Sorry, there is a merge conflict :| |
FORMAT1 NEWLINE FORMAT2 should use FORMAT1 for non-recent (old) files and FORMAT2 for recent files; the assignment was reversed.
sylvestre
force-pushed
the
ls-time-style-recent-old
branch
from
July 4, 2026 16:32
3be1309 to
c5ecc52
Compare
Merging this PR will improve performance by 4.88%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
|
GNU testsuite comparison: |
|
Hi, this needs attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FORMAT1 NEWLINE FORMAT2 should use FORMAT1 for non-recent (old) files and FORMAT2 for recent files; the assignment was reversed.
Closes: #12676