Removed computed MAC address from firmware headers model

No longer necessary now that we can use the Setup API to set the API key for a device. This means you can use either the model ID or, soon, the API key.

Issue: 347
Milestone: minor

Author: bkuhlmann

app/actions/api/setup/show.rb

@@ -39,7 +39,7 @@ def provision_device model
             firmware_version, model_name = model.to_h.values_at :firmware_version, :model_name
 
             provisioner.call model_id: find_model_id(model_name),
-                             mac_address: model.computed_mac_address,
+                             mac_address: model.mac_address,
                              firmware_version:
           end
 

app/aspects/devices/synchronizer.rb

@@ -22,7 +22,7 @@ def call(headers) = pipe firmware_parser.call(headers), :update
 
         def update result, at: Time.now
           result.bind do |model|
-            device = repository.update_by_mac_address model.computed_mac_address,
+            device = repository.update_by_mac_address model.mac_address,
                                                       **model.device_attributes,
                                                       synced_at: at
             device ? Success(device) : Failure("Unable to find device by MAC address.")

app/aspects/firmware/headers/model.rb

@@ -41,8 +41,6 @@ def initialize(**)
             freeze
           end
 
-          def computed_mac_address = mac_address || api_key
-
           def device_attributes
             {
               battery_charge:,

spec/app/aspects/firmware/headers/model_spec.rb

@@ -70,21 +70,6 @@
     end
   end
 
-  describe "#computed_mac_address" do
-    it "answers MAC address when present" do
-      expect(record.computed_mac_address).to eq("A1:B2:C3:D4:E5:F6")
-    end
-
-    it "answers MAC address when MAC address isn't present but API Key is" do
-      record = described_class[api_key: "A1:B2:C3:D4:E5:F6"]
-      expect(record.computed_mac_address).to eq("A1:B2:C3:D4:E5:F6")
-    end
-
-    it "answers nil when MAC address and API Key aren't present" do
-      expect(described_class.new.computed_mac_address).to be(nil)
-    end
-  end
-
   describe "#device_attributes" do
     it "answers device attributes" do
       expect(record.device_attributes).to eq(