[MSHADE-307] Ensure some default transformers and filters are set up if none is configured

[sos-jira-migration-bot]

Romain Manni-Bucau opened MSHADE-307 and commented

If no configuration for transformer (1) and filter (2) then these defaults would be used

1. services and manifest transformers added if not set by the user
2. META-INF/*SF|DSA|RSA excluded in all jars

---

Remote Links:

• GitHub Pull Request #11
  
• GitHub Pull Request #12
  

[sos-jira-migration-bot]

Romain Manni-Bucau commented

PR sent to illustrate the idea: apache/maven-shade-plugin#11

I suspect we can go further supporting more merges OOTB (properties etc) but this can be enhanced later.

[sos-jira-migration-bot]

Elliotte Rusty Harold commented

Possible. The tricky question here is what if someone adds a different transformer? Are the default transformers removed? Is that what's expected? If not, then how are they removed?

 

I'm going to close this absent a more complete proposal with consensus from the maintainers.

[sos-jira-migration-bot]

Romain Manni-Bucau commented

Elliotte Rusty Harold first "agreed" step was to use defaults only when no custom transformer was set up. That said another pass was needed to ensure we can also have some merge strategy not requiring as much config as setting up all transformers (guess it was https://github.com/apache/maven-shade-plugin/pull/11/files#diff-aad819f3f09a8e462cbca09c51bef146R762).