Skip to content

Commit 6e652c2

Browse files
ci: github actions: use runner.temp instead of hardcoded /tmp (dagger#9226)
1 parent d5a67f2 commit 6e652c2

2 files changed

Lines changed: 26 additions & 30 deletions

File tree

.github/actions/call/action.yml

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ runs:
3737
- name: Setup
3838
shell: bash
3939
run: |
40-
mkdir -p /tmp/actions/call
41-
touch /tmp/actions/call/local-envs
40+
mkdir -p ${{ runner.temp }}/actions/call
41+
touch ${{ runner.temp }}/actions/call/local-envs
4242
4343
- name: Install dagger
4444
shell: bash
@@ -76,9 +76,9 @@ runs:
7676
exit 1
7777
fi
7878
79-
# put env variables in /tmp/actions/call/local-envs instead of
79+
# put env variables in ${{ runner.temp }}/actions/call/local-envs instead of
8080
# $GITHUB_ENV to avoid leaking into parent workflow
81-
(cd .dagger/mage; go run main.go -w ../.. engine:dev) | tee /tmp/actions/call/local-envs
81+
(cd .dagger/mage; go run main.go -w ../.. engine:dev) | tee ${{ runner.temp }}/actions/call/local-envs
8282
8383
echo "::endgroup::"
8484
env:
@@ -91,7 +91,7 @@ runs:
9191
- name: Wait for dagger to be ready
9292
shell: bash
9393
run: |
94-
source /tmp/actions/call/local-envs
94+
source ${{ runner.temp }}/actions/call/local-envs
9595
9696
echo "::group::Dagger client version"
9797
dagger --silent version
@@ -104,11 +104,11 @@ runs:
104104
- name: ${{ inputs.function }}
105105
shell: bash
106106
run: |
107-
source /tmp/actions/call/local-envs
107+
source ${{ runner.temp }}/actions/call/local-envs
108108
109109
function redirect_logs() {
110110
if [[ "${{ inputs.upload-logs }}" == "true" ]]; then
111-
"$@" &> /tmp/actions/call/call.log
111+
"$@" &> ${{ runner.temp }}/actions/call/call.log
112112
elif [[ -n "${{ inputs.redirect }}" ]]; then
113113
"$@" | tee "${{ inputs.redirect }}"
114114
else
@@ -135,24 +135,19 @@ runs:
135135
uses: actions/upload-artifact@v4
136136
with:
137137
name: call-logs-${{ runner.name }}-${{ github.job }}
138-
path: /tmp/actions/call/call.log
138+
path: ${{ runner.temp }}/actions/call/call.log
139139
overwrite: true
140140

141141
- name: Capture dev engine logs
142142
if: always() && inputs.dev-engine == 'true'
143143
shell: bash
144144
run: |
145-
docker logs dagger-engine.dev-${{ runner.name }} &> /tmp/actions/call/engine.log
145+
docker logs dagger-engine.dev-${{ runner.name }} &> ${{ runner.temp }}/actions/call/engine.log
146146
147147
- name: Archive engine logs
148148
if: always() && inputs.dev-engine == 'true'
149149
uses: actions/upload-artifact@v4
150150
with:
151151
name: engine-logs-${{ runner.name }}
152-
path: /tmp/actions/call/engine.log
152+
path: ${{ runner.temp }}/actions/call/engine.log
153153
overwrite: true
154-
155-
- name: Cleanup
156-
shell: bash
157-
run: |
158-
rm -rf /tmp/actions/call

.github/workflows/benchmark.yml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,23 @@ jobs:
2828
- name: dagger init (go)
2929
shell: bash
3030
run: |
31-
mkdir -p /tmp/benchmark
32-
cd /tmp/benchmark
31+
mkdir -p ${{ runner.temp }}/benchmark
32+
cd ${{ runner.temp }}/benchmark
3333
3434
dagger init --name=benchmark --sdk=go
3535
3636
- name: dagger functions@initial (go)
3737
shell: bash
3838
run: |
3939
dagger functions
40-
working-directory: /tmp/benchmark
40+
working-directory: ${{ runner.temp }}/benchmark
4141

4242
- name: dagger functions@cached (go)
4343
shell: bash
4444
run: |
4545
dagger functions
46-
working-directory: /tmp/benchmark
46+
47+
working-directory: ${{ runner.temp }}/benchmark
4748

4849
- name: dagger functions@modified (go)
4950
shell: bash
@@ -52,7 +53,7 @@ jobs:
5253
[ -f "main.go" ] && echo >> main.go
5354
5455
dagger functions
55-
working-directory: /tmp/benchmark
56+
working-directory: ${{ runner.temp }}/benchmark
5657

5758
benchmark-python:
5859
name: Benchmark (Python)
@@ -65,22 +66,22 @@ jobs:
6566
- name: dagger init (python)
6667
shell: bash
6768
run: |
68-
mkdir -p /tmp/benchmark
69-
cd /tmp/benchmark
69+
mkdir -p ${{ runner.temp }}/benchmark
70+
cd ${{ runner.temp }}/benchmark
7071
7172
dagger init --name=benchmark --sdk=python
7273
7374
- name: dagger functions@initial (python)
7475
shell: bash
7576
run: |
7677
dagger functions
77-
working-directory: /tmp/benchmark
78+
working-directory: ${{ runner.temp }}/benchmark
7879

7980
- name: dagger functions@cached (python)
8081
shell: bash
8182
run: |
8283
dagger functions
83-
working-directory: /tmp/benchmark
84+
working-directory: ${{ runner.temp }}/benchmark
8485

8586
- name: dagger functions@modified (python)
8687
shell: bash
@@ -89,7 +90,7 @@ jobs:
8990
[ -f "src/main/__init__.py" ] && echo >> src/main/__init__.py
9091
9192
dagger functions
92-
working-directory: /tmp/benchmark
93+
working-directory: ${{ runner.temp }}/benchmark
9394

9495
benchmark-typescript:
9596
name: Benchmark (TypeScript::${{ matrix.package-manager }})
@@ -106,8 +107,8 @@ jobs:
106107
- name: dagger init (typescript::${{ matrix.package-manager }})
107108
shell: bash
108109
run: |
109-
mkdir -p /tmp/benchmark
110-
cd /tmp/benchmark
110+
mkdir -p ${{ runner.temp }}/benchmark
111+
cd ${{ runner.temp }}/benchmark
111112
112113
if [ "${{ matrix.package-manager }}" == "pnpm" ]; then
113114
cat << EOF > package.json
@@ -182,13 +183,13 @@ jobs:
182183
shell: bash
183184
run: |
184185
dagger functions
185-
working-directory: /tmp/benchmark
186+
working-directory: ${{ runner.temp }}/benchmark
186187

187188
- name: dagger functions@cached (typescript::${{ matrix.package-manager }})
188189
shell: bash
189190
run: |
190191
dagger functions
191-
working-directory: /tmp/benchmark
192+
working-directory: ${{ runner.temp }}/benchmark
192193

193194
- name: dagger functions@modified (typescript::${{ matrix.package-manager }})
194195
shell: bash
@@ -197,4 +198,4 @@ jobs:
197198
[ -f "src/index.ts" ] && echo >> src/index.ts
198199
199200
dagger functions
200-
working-directory: /tmp/benchmark
201+
working-directory: ${{ runner.temp }}/benchmark

0 commit comments

Comments
 (0)