From df09feb5f7ed29e09dfff2bb459628afeb714057 Mon Sep 17 00:00:00 2001 From: ejahnGithub Date: Mon, 8 Jun 2026 13:29:18 -0400 Subject: [PATCH 1/5] monitoring: make workloads dashboard plan idempotent The GCP Monitoring API strips default-valued fields (xPos: 0, yPos: 0) from the dashboard JSON it returns, so every subsequent terraform plan showed a spurious 'xPos = 0' / 'yPos = 0' update against the workloads dashboard. Drop the explicit zero defaults from the source JSON so the rendered config matches what the API returns. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ejahnGithub --- gcp/modules/monitoring/infra/workloads.json | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gcp/modules/monitoring/infra/workloads.json b/gcp/modules/monitoring/infra/workloads.json index 3c99fd5..256902c 100644 --- a/gcp/modules/monitoring/infra/workloads.json +++ b/gcp/modules/monitoring/infra/workloads.json @@ -4,8 +4,6 @@ "columns": 12, "tiles": [ { - "xPos": 0, - "yPos": 0, "width": 12, "height": 4, "widget": { @@ -21,7 +19,6 @@ } }, { - "xPos": 0, "yPos": 4, "width": 6, "height": 4, @@ -95,7 +92,6 @@ } }, { - "xPos": 0, "yPos": 8, "width": 6, "height": 4, @@ -185,7 +181,6 @@ } }, { - "xPos": 0, "yPos": 12, "width": 6, "height": 4, @@ -259,7 +254,6 @@ } }, { - "xPos": 0, "yPos": 16, "width": 6, "height": 4, @@ -336,7 +330,6 @@ } }, { - "xPos": 0, "yPos": 20, "width": 6, "height": 4, @@ -414,7 +407,6 @@ } }, { - "xPos": 0, "yPos": 24, "width": 6, "height": 4, @@ -486,7 +478,6 @@ } }, { - "xPos": 0, "yPos": 28, "width": 12, "height": 4, From 402f72cc536ac4e10f5b2ad5e51e16b3ff3fe92f Mon Sep 17 00:00:00 2001 From: ejahnGithub Date: Tue, 9 Jun 2026 16:33:20 -0400 Subject: [PATCH 2/5] TEMP: tweak workloads dashboard displayName to verify plan Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ejahnGithub --- gcp/modules/monitoring/infra/workloads.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcp/modules/monitoring/infra/workloads.json b/gcp/modules/monitoring/infra/workloads.json index 256902c..36eb673 100644 --- a/gcp/modules/monitoring/infra/workloads.json +++ b/gcp/modules/monitoring/infra/workloads.json @@ -1,5 +1,5 @@ { - "displayName": "Workloads CPU & Memory", + "displayName": "Workloads CPU & Memory (plan verification)", "mosaicLayout": { "columns": 12, "tiles": [ From 22921bf249913edc4b3c03df3249f4baec35e105 Mon Sep 17 00:00:00 2001 From: ejahnGithub Date: Tue, 9 Jun 2026 16:38:15 -0400 Subject: [PATCH 3/5] TEMP: tweak spanner dashboard displayName in tf to verify plan Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ejahnGithub --- gcp/modules/monitoring/infra/dashboards.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcp/modules/monitoring/infra/dashboards.tf b/gcp/modules/monitoring/infra/dashboards.tf index f7e5f8a..bfc0715 100644 --- a/gcp/modules/monitoring/infra/dashboards.tf +++ b/gcp/modules/monitoring/infra/dashboards.tf @@ -17,7 +17,7 @@ resource "google_monitoring_dashboard" "spanner_cpu_dashboard" { dashboard_json = < Date: Tue, 9 Jun 2026 16:42:32 -0400 Subject: [PATCH 4/5] Revert TEMP displayName change in workloads.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ejahnGithub --- gcp/modules/monitoring/infra/workloads.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcp/modules/monitoring/infra/workloads.json b/gcp/modules/monitoring/infra/workloads.json index 36eb673..256902c 100644 --- a/gcp/modules/monitoring/infra/workloads.json +++ b/gcp/modules/monitoring/infra/workloads.json @@ -1,5 +1,5 @@ { - "displayName": "Workloads CPU & Memory (plan verification)", + "displayName": "Workloads CPU & Memory", "mosaicLayout": { "columns": 12, "tiles": [ From 7666c06ef6af0f081388f7bdd9e497be2728e7f0 Mon Sep 17 00:00:00 2001 From: ejahnGithub Date: Tue, 9 Jun 2026 16:49:37 -0400 Subject: [PATCH 5/5] Revert plan-verification label; keep minor displayName tweak Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ejahnGithub --- gcp/modules/monitoring/infra/dashboards.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcp/modules/monitoring/infra/dashboards.tf b/gcp/modules/monitoring/infra/dashboards.tf index bfc0715..9babf99 100644 --- a/gcp/modules/monitoring/infra/dashboards.tf +++ b/gcp/modules/monitoring/infra/dashboards.tf @@ -17,7 +17,7 @@ resource "google_monitoring_dashboard" "spanner_cpu_dashboard" { dashboard_json = <