fix(desktop): fail file upload on non-2xx instead of using the error body as a CID

The file-upload helpers read the daemon response body as the CID without
checking the status. On a failed upload the daemon returns a non-2xx with the
error text in the body, so that text became the CID and got baked into
documents as `ipfs://Failed to add file...`. Guard response.ok in the five
upload paths that lacked it (the other five already did).

Author: juligasa

frontend/apps/desktop/src/app-web-importing.ts

@@ -28,7 +28,12 @@ export async function uploadFile(file: Blob | string) {
     method: 'POST',
     body: formData,
   })
+  // Guard the status: on failure the daemon returns a non-2xx with the error in
+  // the body, and returning that text lets it become a `ipfs://<error>` URL.
   const data = await response.text()
+  if (!response.ok) {
+    throw new Error(`File upload failed (${response.status}): ${data}`)
+  }
   return data
 }
 

frontend/apps/desktop/src/utils/file-upload.ts

@@ -9,8 +9,15 @@ export async function fileUpload(file: File) {
       method: 'POST',
       body: formData,
     })
-    return await response.text()
   } catch (error: any) {
     throw new Error(error)
   }
+  // On failure the daemon returns a non-2xx status with the error in the body.
+  // Guard the status before returning it: otherwise the error text is used as
+  // the CID and ends up baked into a document as `ipfs://<error message>`.
+  const body = await response.text()
+  if (!response.ok) {
+    throw new Error(`File upload failed (${response.status}): ${body}`)
+  }
+  return body
 }

frontend/apps/desktop/src/utils/media-drag.ts

@@ -63,6 +63,9 @@ export async function handleDragMedia(file: File) {
       method: 'POST',
       body: formData,
     })
+    if (!response.ok) {
+      throw new Error(`File upload failed (${response.status}): ${await response.text()}`)
+    }
     const data = await response.text()
     return {
       url: data ? `ipfs://${data}` : '',

frontend/packages/editor/src/media-container.tsx

@@ -105,6 +105,9 @@ export const MediaContainer = ({
           method: 'POST',
           body: formData,
         })
+        if (!response.ok) {
+          throw new Error(`File upload failed (${response.status}): ${await response.text()}`)
+        }
         const data = await response.text()
 
         markBlockUploaded(block.id)

frontend/packages/editor/src/utils.ts

@@ -238,6 +238,9 @@ export async function handleDragMedia(
       method: 'POST',
       body: formData,
     })
+    if (!response.ok) {
+      throw new Error(`File upload failed (${response.status}): ${await response.text()}`)
+    }
     const data = await response.text()
     return {
       url: data ? `ipfs://${data}` : '',