File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 11# Releasing the SchemaLock Zed extension
22
3- The extension versions independently of ` schemalock/app ` . ` .app-version ` and the
3+ The extension versions independently of ` schemalock/schemalock ` . ` .app-version ` and the
44` APP_VERSION ` const in ` src/lib.rs ` pin which app tag the extension downloads;
55they must always match.
66
7- > ** Why the CDN, not GitHub releases?** ` schemalock/app ` is a ** private ** repo, so
8- > Zed's anonymous GitHub API calls 404. The extension instead downloads from the
9- > public CDN at ` https://cdn.schemalock.dev/bin/<tag>/<asset> ` . Publishing those
7+ > ** Why the CDN, not GitHub releases?** The binaries are published to the CDN by
8+ > the app release pipeline, and the WASM sandbox has no GitHub API credentials. The
9+ > extension downloads from the public CDN at ` https://cdn.schemalock.dev/bin/<tag>/<asset> ` . Publishing those
1010> objects is part of the app release (see "Publishing binaries to the CDN" below).
1111
1212## Bumping the pinned app version
@@ -27,7 +27,7 @@ they must always match.
27275 . Branch + merge (never commit directly to the default branch) + tag the
2828 extension at the new version.
2929
30- > Schema/protocol changes in ` schemalock/app ` are contract-breaking. Ship the app
30+ > Schema/protocol changes in ` schemalock/schemalock ` are contract-breaking. Ship the app
3131> bump and the extension bump in lockstep so ` .app-version ` always points at a
3232> compatible app.
3333
Original file line number Diff line number Diff line change @@ -15,7 +15,7 @@ pub struct Platform {
1515/// Returns the GitHub release asset name for `platform`, or `None` if SchemaLock
1616/// publishes no prebuilt binary for that os/arch combination.
1717///
18- /// Asset names are the exact `schemalock/app ` release asset filenames.
18+ /// Asset names are the exact `schemalock/schemalock ` release asset filenames.
1919pub fn asset_name ( platform : & Platform ) -> Option < & ' static str > {
2020 match ( platform. os , platform. arch ) {
2121 ( "mac" , "aarch64" ) => Some ( "schemalock-darwin-arm64" ) ,
Original file line number Diff line number Diff line change 44
55use zed_extension_api:: { self as zed, LanguageServerId , Result } ;
66
7- /// The pinned `schemalock/app ` release tag whose binary this extension version
7+ /// The pinned `schemalock/schemalock ` release tag whose binary this extension version
88/// ships against. Keep in lockstep with the `.app-version` file (the file is the
99/// human-facing source of truth; this const is what actually drives the
1010/// download, because the WASM sandbox cannot read repo files at runtime).
1111const APP_VERSION : & str = "v0.3.2" ;
1212
1313/// Public CDN prefix under which the per-tag binaries are published. The full
1414/// asset URL is `<CDN_BASE>/<APP_VERSION>/<asset>`. We download straight from the
15- /// CDN (not the GitHub API) because `schemalock/app` is a private repository —
16- /// only the binaries are public .
15+ /// CDN (not the GitHub API): the binaries are published to the CDN by the app
16+ /// release pipeline, and the WASM sandbox has no GitHub API credentials .
1717const CDN_BASE : & str = "https://cdn.schemalock.dev/bin" ;
1818
1919struct SchemaLockExtension ;
You can’t perform that action at this time.
0 commit comments