Update to BankTabNames#12625
Open
Psyda wants to merge 5 commits into
Open
Conversation
'Inject the client's Gson instead of using fresh instances'
Swapped missed awt.desktop usage to Runelite's LinkBrowser
Contributor
|
You need to add |
Contributor
Author
I've added build=standard to the runelite-plugin.properties |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #11105
It has been reviewed here: #11105, but I was unavailable for the last month to provide an update. Sorry for the delay, work has been rough, and the changes were implemented.
I removed the images I didn't create, so it now only includes my work. I also swappedthe awt.Desktop usage.
This replaces the single-icon sprite editor with a multi-icon system and overhauls how tab overlays are rendered.
Why: The old editor had a persistent issue where sprite IDs shuffled whenever the icon list updated, breaking user configs. The rendering was also clipped to the tab bar boundaries, limiting what users could do with custom icons and offsets. Both problems required a ground-up rethink rather than incremental patches .I held off on shipping incremental fixes because most of the reported problems shared root causes in the rendering and sprite ID systems. Fixing them properly meant reworking both at the same time.
What changed:
Tabs now support multiple icons (items, skills, game sprites, custom PNGs) with per-icon size, offset, z-index, and aspect-ratio-locked resizing. Icons and text render on Bankmain.INFINITE instead of Bankmain.TABS, removing the clipping limitation. Game sprite dimensions are resolved from SpritePixels.getMaxWidth/getMaxHeight rather than the trimmed BufferedImage from SpriteManager.getSprite(), which was causing sprites to render at wrong sizes.
The side panel got a scrollable icon editor, curated sprite category browser, fit toggle for stacking/overlay designs, config presets with import/export (versioned JSON), and panel visibility options.
See the updated README for full feature documentation.
Testing: Tested across all three tab display modes (item, digit, roman numeral), with bank settings page open/closed, with 1-8+ icons per tab, with custom user PNGs, and with various game sprites including non-square and padded sprites. Config migration from old single-icon format verified.