Skip to content

Commit dddb4d2

Browse files
rubysclaude
andcommitted
Fix remaining lint errors missed in previous commit
- fly_replay_test.go: use t.Setenv, remove unused os import - validation_test.go: fix unchecked tmpFile.Close and os.Remove calls Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 8c39e5e commit dddb4d2

2 files changed

Lines changed: 10 additions & 13 deletions

File tree

internal/config/validation_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -215,12 +215,12 @@ applications:
215215
if err != nil {
216216
t.Fatalf("Failed to create temp file: %v", err)
217217
}
218-
defer os.Remove(tmpFile.Name())
218+
defer func() { _ = os.Remove(tmpFile.Name()) }()
219219

220220
if _, err := tmpFile.WriteString(tt.config); err != nil {
221221
t.Fatalf("Failed to write test config: %v", err)
222222
}
223-
tmpFile.Close()
223+
_ = tmpFile.Close()
224224

225225
config, err := LoadConfig(tmpFile.Name())
226226

@@ -390,12 +390,12 @@ managed_processes: []
390390
if err != nil {
391391
t.Fatalf("Failed to create temp file: %v", err)
392392
}
393-
defer os.Remove(tmpFile.Name())
393+
defer func() { _ = os.Remove(tmpFile.Name()) }()
394394

395395
if _, err := tmpFile.WriteString(tt.config); err != nil {
396396
t.Fatalf("Failed to write test config: %v", err)
397397
}
398-
tmpFile.Close()
398+
_ = tmpFile.Close()
399399

400400
config, err := LoadConfig(tmpFile.Name())
401401
if err != nil {
@@ -640,12 +640,12 @@ applications:
640640
if err != nil {
641641
t.Fatalf("Failed to create temp file: %v", err)
642642
}
643-
defer os.Remove(tmpFile.Name())
643+
defer func() { _ = os.Remove(tmpFile.Name()) }()
644644

645645
if _, err := tmpFile.WriteString(tt.config); err != nil {
646646
t.Fatalf("Failed to write test config: %v", err)
647647
}
648-
tmpFile.Close()
648+
_ = tmpFile.Close()
649649

650650
// Configuration should load without errors even with problematic variable substitution
651651
config, err := LoadConfig(tmpFile.Name())
@@ -717,12 +717,12 @@ hooks:
717717
if err != nil {
718718
b.Fatalf("Failed to create temp file: %v", err)
719719
}
720-
defer os.Remove(tmpFile.Name())
720+
defer func() { _ = os.Remove(tmpFile.Name()) }()
721721

722722
if _, err := tmpFile.WriteString(testConfig); err != nil {
723723
b.Fatalf("Failed to write test config: %v", err)
724724
}
725-
tmpFile.Close()
725+
_ = tmpFile.Close()
726726

727727
b.ResetTimer()
728728
for i := 0; i < b.N; i++ {

internal/server/fly_replay_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package server
33
import (
44
"encoding/json"
55
"net/http/httptest"
6-
"os"
76
"strings"
87
"testing"
98

@@ -129,8 +128,7 @@ func TestHandleFlyReplay(t *testing.T) {
129128
t.Run(tt.name, func(t *testing.T) {
130129
// Set environment variable for current app
131130
if tt.currentApp != "" {
132-
os.Setenv("FLY_APP_NAME", tt.currentApp)
133-
defer os.Unsetenv("FLY_APP_NAME")
131+
t.Setenv("FLY_APP_NAME", tt.currentApp)
134132
}
135133

136134
cfg := &config.Config{}
@@ -224,8 +222,7 @@ func TestHandleFlyReplay(t *testing.T) {
224222
}
225223

226224
func TestHandleFlyReplay_WithAuthorization(t *testing.T) {
227-
os.Setenv("FLY_APP_NAME", "myapp")
228-
defer os.Unsetenv("FLY_APP_NAME")
225+
t.Setenv("FLY_APP_NAME", "myapp")
229226

230227
cfg := &config.Config{}
231228
req := httptest.NewRequest("GET", "/test", nil)

0 commit comments

Comments
 (0)