Add request url to error message for easier debugging (#216)

Author: steffilazerte

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: weathercan
 Type: Package
 Title: Download Weather Data from Environment and Climate Change Canada
-Version: 1.0.0
+Version: 1.0.1
 Authors@R: c(
      person("Steffi", "LaZerte", email = "sel@steffilazerte.ca", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-7690-8360")),
      person("Sam", "Albers", email = "sam.albers@gmail.com", role = c("aut"), comment = c(ORCID = "0000-0002-9270-7884")),

NEWS.md

@@ -1,3 +1,7 @@
+# weathercan 1.0.1
+
+- Add request url to error message for easier debugging (#216)
+
 # weathercan 1.0.0
 
 - Fix ECCC change to normals download query parameters again (#207)

R/api.R

@@ -69,7 +69,8 @@ get_check <- function(url, query = NULL) {
     wc_stop(
       "API could not fetch data with this query\n",
       "Please, open an issue on https://github.com/ropensci/weathercan/issues and share ",
-      "the details of your attempted download."
+      "the details of your attempted download: ",
+      req$request$url
     )
   }
   req

tests/testthat/test_04_weather_raw.R

@@ -13,11 +13,14 @@ test_that("weather_html/raw (hour) download a data frame", {
 
   expect_silent(wd <- weather_raw(wd))
 
-  # expect_error(
-  #   weather_html(station_id = 9999999999,
-  #                date = as.Date("2014-01-01"),
-  #                interval = "hour"),
-  #   "API could not fetch data with this query")
+  expect_error(
+    weather_html(
+      station_id = 9999999999,
+      date = as.Date("2014-01-01"),
+      interval = "hour"
+    ),
+    "API could not fetch data with this query"
+  )
 
   ## Basics
   expect_s3_class(wd, "data.frame")