Enable non-zero mu_r#52
Open
cjvogl wants to merge 10 commits into
Open
Conversation
… mur; added exception for Sedimentation::rain_fall_speeds_numerical that does not support non-zero mur
…meter for mu_r != 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of sedimentation, evaporation, and size limiters to enable non-zero mu_r (e.g., mu_r=1 as used by EAMxx).
Tested with the following:
./rainshaft --use_zero_mur=1from this branch vs./rainshaftfrommain./rainshaft --use_lookup=1 --use_zero_mur=1from this branch vs./rainshaft --use_lookup=1frommainNote that machine precision here refers to an RMS difference$\approx 10^{-20}$ relative to the RMS norm of the prior solution $\approx 10^{-4}$
Here is a summary of the changes, as compiled by Claude Code, seemingly mostly from my commit messages (with me confirming the accuracy of the description):
Key Changes
Core Physics Refactoring:
proper gamma function arguments
Configuration:
Build System: