Remove the /team/select page

- Topbar dropdown now lists all teams (scrolls after ~5 to be sure, though no users have more than 5 teams yet)
- Empty-state "Go to team sites" now has a dropdown button that routes directly instead of via a separate page
- Deleted the route, controller, template, and related tests

Author: sanne-san

lib/plausible_web/controllers/auth_controller.ex

@@ -38,7 +38,6 @@ defmodule PlausibleWeb.AuthController do
            :verify_2fa_setup,
            :disable_2fa,
            :generate_2fa_recovery_codes,
-           :select_team,
            :switch_team
          ]
   )
@@ -61,51 +60,6 @@ defmodule PlausibleWeb.AuthController do
     TwoFactor.Session.clear_2fa_user(conn)
   end
 
-  def select_team(conn, _params) do
-    current_user = conn.assigns.current_user
-    current_team = conn.assigns[:current_team]
-
-    owner_name_fn = fn owner ->
-      if owner.id == current_user.id do
-        "You"
-      else
-        owner.name
-      end
-    end
-
-    teams =
-      current_user
-      |> Teams.Users.teams()
-      |> Enum.filter(& &1.setup_complete)
-      |> Enum.map(fn team ->
-        current_team? = current_team && team.id == current_team.id
-
-        owners =
-          Enum.map_join(team.owners, ", ", &owner_name_fn.(&1))
-
-        many_owners? = length(team.owners) > 1
-
-        %{
-          identifier: team.identifier,
-          name: team.name,
-          current?: current_team?,
-          many_owners?: many_owners?,
-          owners: owners
-        }
-      end)
-
-    case teams do
-      [] ->
-        redirect(conn, to: Routes.site_path(conn, :index))
-
-      [%{identifier: sole_team_identifier}] ->
-        redirect(conn, to: Routes.site_path(conn, :index, __team: sole_team_identifier))
-
-      [_ | _] ->
-        render(conn, "select_team.html", teams_selection: teams)
-    end
-  end
-
   def activate_form(conn, params) do
     user = conn.assigns.current_user
     flow = params["flow"] || PlausibleWeb.Flows.register()

lib/plausible_web/live/auth_context.ex

@@ -87,16 +87,9 @@ defmodule PlausibleWeb.Live.AuthContext do
 
         %{current_user: user} ->
           user.team_memberships
+          |> Enum.filter(& &1.team.setup_complete)
           |> Enum.sort_by(fn tm -> [tm.role != :owner, tm.team_id] end)
           |> Enum.map(&Map.fetch!(&1, :team))
-          |> Enum.take(3)
-      end)
-      |> assign_new(:teams_count, fn
-        %{current_user: nil} -> 0
-        %{current_user: user} -> length(user.team_memberships)
-      end)
-      |> assign_new(:more_teams?, fn context ->
-        context.teams_count > 3
       end)
 
     {:cont, socket}

lib/plausible_web/live/sites.ex

@@ -205,13 +205,36 @@ defmodule PlausibleWeb.Live.Sites do
             <Heroicons.plus class="size-4" /> Add website
           </.button_link>
           <.button_link
-            :if={not Teams.setup?(@current_team) and @has_sites?}
-            href={Routes.auth_path(@socket, :select_team)}
+            :if={not Teams.setup?(@current_team) and @has_sites? and length(@teams) == 1}
+            href={Routes.site_path(@socket, :index, __team: hd(@teams).identifier)}
             theme="secondary"
             mt?={false}
           >
             Go to team sites
           </.button_link>
+
+          <PrimaDropdown.dropdown
+            :if={not Teams.setup?(@current_team) and @has_sites? and length(@teams) > 1}
+            id="go-to-team-dropdown"
+          >
+            <PrimaDropdown.dropdown_trigger id="go-to-team-dropdown-trigger" theme="secondary">
+              Go to team sites
+              <Heroicons.chevron_down mini class="size-4 mt-0.5" />
+            </PrimaDropdown.dropdown_trigger>
+
+            <PrimaDropdown.dropdown_menu id="go-to-team-dropdown-menu">
+              <div class="max-h-[200px] overflow-y-auto">
+                <PrimaDropdown.dropdown_item
+                  :for={team <- @teams}
+                  as={&link/1}
+                  id={"go-to-team-dropdown-menuitem-#{team.identifier}"}
+                  href={Routes.site_path(@socket, :index, __team: team.identifier)}
+                >
+                  {Teams.name(team)}
+                </PrimaDropdown.dropdown_item>
+              </div>
+            </PrimaDropdown.dropdown_menu>
+          </PrimaDropdown.dropdown>
         </div>
       </div>
 

lib/plausible_web/plugs/auth_plug.ex

@@ -54,14 +54,11 @@ defmodule PlausibleWeb.AuthPlug do
           |> Enum.find(%{}, &(&1.role == :owner and &1.team.setup_complete == false))
           |> Map.get(:team)
 
-        teams_count = length(user.team_memberships)
-
         teams =
           user.team_memberships
           |> Enum.filter(& &1.team.setup_complete)
           |> Enum.sort_by(fn tm -> [tm.role != :owner, tm.team_id] end)
           |> Enum.map(&Map.fetch!(&1, :team))
-          |> Enum.take(3)
 
         Plausible.OpenTelemetry.add_user_attributes(user)
 
@@ -80,9 +77,7 @@ defmodule PlausibleWeb.AuthPlug do
         |> assign(:my_team, my_team)
         |> assign(:current_team, current_team || my_team)
         |> assign(:current_team_role, current_team_role || (my_team && :owner))
-        |> assign(:teams_count, teams_count)
         |> assign(:teams, teams)
-        |> assign(:more_teams?, teams_count > 3)
 
       {:error, :session_expired, user_session} ->
         assign(conn, :expired_session, user_session)

lib/plausible_web/plugs/require_account.ex

@@ -12,8 +12,7 @@ defmodule PlausibleWeb.RequireAccountPlug do
   @force_2fa_exceptions [
     ["2fa", "setup", "force-initiate"],
     ["2fa", "setup", "initiate"],
-    ["2fa", "setup", "verify"],
-    ["team", "select"]
+    ["2fa", "setup", "verify"]
   ]
 
   def init(options) do

lib/plausible_web/router.ex

@@ -540,7 +540,6 @@ defmodule PlausibleWeb.Router do
       get "/sso/notice", SSOController, :provision_notice
       get "/sso/issue", SSOController, :provision_issue
       get "/logout", AuthController, :logout
-      get "/team/select", AuthController, :select_team
     end
 
     scope "/", PlausibleWeb do
@@ -557,7 +556,6 @@ defmodule PlausibleWeb.Router do
 
     on_ce do
       get "/logout", AuthController, :logout
-      get "/team/select", AuthController, :select_team
     end
 
     delete "/me", AuthController, :delete_me

lib/plausible_web/templates/auth/select_team.html.heex

@@ -88,7 +88,6 @@
                       teams={@teams}
                       my_team={@my_team}
                       current_team={@current_team}
-                      more_teams?={@more_teams?}
                     />
                     <.dropdown_divider />
                     <.dropdown_item href={Routes.settings_path(@conn, :index)}>

lib/plausible_web/templates/layout/_header.html.heex

@@ -166,7 +166,6 @@ defmodule PlausibleWeb.LayoutView do
   attr :teams, :list, required: true
   attr :my_team, :any, default: nil
   attr :current_team, :any, default: nil
-  attr :more_teams?, :boolean, required: true
 
   def team_switcher(assigns) do
     teams = assigns[:teams]
@@ -202,26 +201,25 @@ defmodule PlausibleWeb.LayoutView do
       <.dropdown_item>
         <div class="text-xs text-gray-500 dark:text-gray-400">Teams</div>
       </.dropdown_item>
-      <.dropdown_item
-        :for={team <- @teams}
-        href={Routes.site_path(@conn, :index, __team: team.identifier)}
-      >
-        <p
-          class={[
-            if(team.id == @selected_id,
-              do: "border-r-4 border-indigo-400 font-bold",
-              else: "font-medium"
-            ),
-            "truncate text-gray-900 dark:text-gray-100 pr-4"
-          ]}
-          role="none"
+      <div class="max-h-[200px] overflow-y-auto">
+        <.dropdown_item
+          :for={team <- @teams}
+          href={Routes.site_path(@conn, :index, __team: team.identifier)}
         >
-          {Teams.name(team)}
-        </p>
-      </.dropdown_item>
-      <.dropdown_item :if={@more_teams?} href={Routes.auth_path(@conn, :select_team)}>
-        Switch to Another Team
-      </.dropdown_item>
+          <p
+            class={[
+              if(team.id == @selected_id,
+                do: "border-r-4 border-indigo-400 font-bold",
+                else: "font-medium"
+              ),
+              "truncate text-gray-900 dark:text-gray-100 pr-4"
+            ]}
+            role="none"
+          >
+            {Teams.name(team)}
+          </p>
+        </.dropdown_item>
+      </div>
       """
     else
       ~H""

lib/plausible_web/views/layout_view.ex

@@ -2095,48 +2095,6 @@ defmodule PlausibleWeb.AuthControllerTest do
     end
   end
 
-  describe "GET /team/select" do
-    setup [:create_user, :log_in]
-
-    test "redirects to /sites if no teams available", %{conn: conn} do
-      conn = get(conn, Routes.auth_path(conn, :select_team))
-      assert redirected_to(conn, 302) == Routes.site_path(conn, :index)
-    end
-
-    test "redirects to /sites?__team if one team set up available", %{conn: conn, user: user} do
-      new_site(owner: user)
-      team = team_of(user)
-      assert Plausible.Teams.complete_setup(team)
-      conn = get(conn, Routes.auth_path(conn, :select_team))
-      assert redirected_to(conn, 302) == Routes.site_path(conn, :index, __team: team.identifier)
-    end
-
-    test "displays team switcher if >1 teams available", %{conn: conn, user: user} do
-      t1 = new_site(owner: user).team
-      t2 = new_site().team
-
-      add_member(t2, user: user, role: :viewer)
-
-      Plausible.Teams.complete_setup(t1)
-      Plausible.Teams.complete_setup(t2)
-
-      conn = get(conn, Routes.auth_path(conn, :select_team))
-      assert html = html_response(conn, 200)
-
-      assert text(html) =~ "Switch your current team"
-
-      assert element_exists?(
-               html,
-               ~s|a[href="#{Routes.site_path(conn, :index, __team: t1.identifier)}"]|
-             )
-
-      assert element_exists?(
-               html,
-               ~s|a[href="#{Routes.site_path(conn, :index, __team: t2.identifier)}"]|
-             )
-    end
-  end
-
   defp login_with_cookie(conn, email, password) do
     conn
     |> post(Routes.auth_path(conn, :login), %{