fix tests command env injection and coverage-safe behavior

Author: coisa

src/Config/ComposerDependencyAnalyserConfig.php

@@ -19,6 +19,8 @@
 
 namespace FastForward\DevTools\Config;
 
+use FastForward\DevTools\Environment\Environment;
+use FastForward\DevTools\Environment\EnvironmentInterface;
 use FastForward\DevTools\Path\DevToolsPathResolver;
 use ShipMonk\ComposerDependencyAnalyser\Config\Configuration;
 use ShipMonk\ComposerDependencyAnalyser\Config\ErrorType;
@@ -86,14 +88,18 @@ final class ComposerDependencyAnalyserConfig
      * Creates the default Composer Dependency Analyser configuration.
      *
      * @param callable|null $customize optional callback to customize the configuration
+     * @param EnvironmentInterface|null $environment optional environment reader used to resolve overrides
      *
      * @return Configuration the configured analyser configuration
      */
-    public static function configure(?callable $customize = null): Configuration
-    {
+    public static function configure(
+        ?callable $customize = null,
+        ?EnvironmentInterface $environment = null,
+    ): Configuration {
+        $environment ??= new Environment();
         $configuration = new Configuration();
 
-        if (! self::shouldShowShadowDependencies()) {
+        if (! self::shouldShowShadowDependencies($environment)) {
             self::applyIgnoresShadowDependencies($configuration);
         }
 
@@ -128,11 +134,15 @@ public static function applyIgnoresShadowDependencies(Configuration $configurati
     /**
      * Determines whether shadow dependency reports SHOULD remain visible.
      *
+     * @param EnvironmentInterface|null $environment optional environment reader used to resolve overrides
+     *
      * @return bool
      */
-    public static function shouldShowShadowDependencies(): bool
+    public static function shouldShowShadowDependencies(?EnvironmentInterface $environment = null): bool
     {
-        return '1' === getenv(self::ENV_SHOW_SHADOW_DEPENDENCIES);
+        $environment ??= new Environment();
+
+        return '1' === $environment->get(self::ENV_SHOW_SHADOW_DEPENDENCIES);
     }
 
     /**

src/Console/Command/ReportsCommand.php

@@ -27,6 +27,7 @@
 use FastForward\DevTools\Process\ProcessBuilderInterface;
 use FastForward\DevTools\Process\ProcessQueueInterface;
 use FastForward\DevTools\Path\ManagedWorkspace;
+use Psr\Log\LogLevel;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
@@ -197,7 +198,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->log(
                 'Skipping coverage report because no tests directory or PHP source files were detected.',
                 $input,
-                logLevel: 'warning',
+                logLevel: LogLevel::WARNING,
             );
         }
 

src/Console/Command/TestsCommand.php

@@ -24,6 +24,7 @@
 use FastForward\DevTools\Console\Input\HasCacheOption;
 use FastForward\DevTools\Console\Input\HasJsonOption;
 use FastForward\DevTools\Composer\Json\ComposerJsonInterface;
+use FastForward\DevTools\Environment\EnvironmentInterface;
 use FastForward\DevTools\Filesystem\FilesystemInterface;
 use FastForward\DevTools\Path\DevToolsPathResolver;
 use FastForward\DevTools\PhpUnit\Bootstrap\BootstrapShimGenerator;
@@ -60,9 +61,9 @@ final class TestsCommand extends Command
     use HasJsonOption;
     use LogsCommandResults;
 
-    private const string AGENT_ENVIRONMENT_VARIABLE = 'AI_AGENT';
+    public const string AGENT_ENVIRONMENT_VARIABLE = 'AI_AGENT';
 
-    private const string AGENT_ENVIRONMENT_VALUE = 'fast-forward/dev-tools';
+    public const string AGENT_ENVIRONMENT_VALUE = 'fast-forward/dev-tools';
 
     private const string PROCESS_LABEL = 'Running PHPUnit Tests';
 
@@ -71,6 +72,8 @@ final class TestsCommand extends Command
      */
     public const string CONFIG = 'phpunit.xml';
 
+    public const string ENV_MINIMUM_COVERAGE = 'FAST_FORWARD_MIN_COVERAGE';
+
     /**
      * @param CoverageSummaryLoaderInterface $coverageSummaryLoader the loader used for `coverage-php` summaries
      * @param ComposerJsonInterface $composer the composer.json reader for autoload information
@@ -80,6 +83,7 @@ final class TestsCommand extends Command
      * @param ProcessBuilderInterface $processBuilder the builder used to assemble the PHPUnit process
      * @param ProcessQueueInterface $processQueue the queue used to execute PHPUnit
      * @param ProjectCapabilitiesResolverInterface $projectCapabilitiesResolver the project capability resolver
+     * @param EnvironmentInterface $environment the environment resolver for CLI-scoped flags
      */
     public function __construct(
         private readonly CoverageSummaryLoaderInterface $coverageSummaryLoader,
@@ -90,6 +94,7 @@ public function __construct(
         private readonly ProcessBuilderInterface $processBuilder,
         private readonly ProcessQueueInterface $processQueue,
         private readonly ProjectCapabilitiesResolverInterface $projectCapabilitiesResolver,
+        private readonly EnvironmentInterface $environment,
     ) {
         parent::__construct();
     }
@@ -193,7 +198,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         if (! $projectCapabilities->canRunTests()) {
             return $this->success(
-                'Skipping PHPUnit tests because no tests directory or PHP source files were detected.',
+                'Skipping PHPUnit tests because no Composer-autoloaded PHP source files were detected.',
                 $input,
                 [
                     'output' => $processOutput,
@@ -249,14 +254,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $result = $this->processQueue->run($processOutput);
         $processResultContext = $this->resolveProcessResultContext($processOutput, $result, $structuredOutput);
 
-        if (self::SUCCESS !== $result || null === $minimumCoverage || null === $coverageReportPath) {
-            if (self::SUCCESS === $result) {
-                return $this->success('PHPUnit tests completed successfully.', $input, $processResultContext);
-            }
-
+        if (self::SUCCESS !== $result) {
             return $this->failure('PHPUnit tests failed.', $input, $processResultContext);
         }
 
+        if (null === $minimumCoverage || null === $coverageReportPath) {
+            return $this->success('PHPUnit tests completed successfully.', $input, $processResultContext);
+        }
+
         [$validationResult, $message, $coverageContext] = $this->validateMinimumCoverage(
             $coverageReportPath,
             $minimumCoverage,
@@ -314,10 +319,9 @@ private function resolveProcessResultContext(
     private function forceAgentReporter(Process $process): void
     {
         $env = $process->getEnv();
+        $parentAgentEnvironment = $this->environment->get(self::AGENT_ENVIRONMENT_VARIABLE);
 
-        if (\array_key_exists(self::AGENT_ENVIRONMENT_VARIABLE, $env) || false !== getenv(
-            self::AGENT_ENVIRONMENT_VARIABLE
-        )) {
+        if (\array_key_exists(self::AGENT_ENVIRONMENT_VARIABLE, $env) || null !== $parentAgentEnvironment) {
             return;
         }
 
@@ -515,9 +519,15 @@ private function resolveMinimumCoverage(InputInterface $input): ?float
         $minimumCoverage = $input->getOption('min-coverage');
 
         if (null === $minimumCoverage) {
+            $minimumCoverage = $this->resolveMinimumCoverageFromEnvironment();
+        }
+
+        if (false === $minimumCoverage || '' === trim((string) $minimumCoverage)) {
             return null;
         }
 
+        $minimumCoverage = trim((string) $minimumCoverage);
+
         if (! is_numeric($minimumCoverage)) {
             throw new InvalidArgumentException('The --min-coverage option MUST be a numeric percentage.');
         }
@@ -531,6 +541,16 @@ private function resolveMinimumCoverage(InputInterface $input): ?float
         return $minimumCoverage;
     }
 
+    /**
+     * Resolves minimum-coverage value from injected environment abstraction.
+     *
+     * @return string|false|null the configured coverage threshold or a falsey fallback
+     */
+    private function resolveMinimumCoverageFromEnvironment(): ?string
+    {
+        return $this->environment->get(self::ENV_MINIMUM_COVERAGE);
+    }
+
     /**
      * @param InputInterface $input the raw parameter definitions
      * @param ProcessBuilderInterface $processBuilder the process builder to extend with coverage arguments

src/Console/DevTools.php

@@ -46,6 +46,8 @@
  */
 final class DevTools extends Application
 {
+    public const string ENV_AUTO_UPDATE = 'FAST_FORWARD_AUTO_UPDATE';
+
     private const string LOGO = <<<'LOGO'
          ____             _____           _
         |  _ \  _____   _|_   _|__   ___ | |___
@@ -201,7 +203,7 @@ private function configureWorkspaceDirectory(InputInterface $input): void
      */
     private function runAutoUpdateWhenRequested(InputInterface $input, OutputInterface $output): void
     {
-        $autoUpdateMode = $this->environment->get('FAST_FORWARD_AUTO_UPDATE', '');
+        $autoUpdateMode = $this->environment->get(self::ENV_AUTO_UPDATE, '');
 
         if (! $input->hasParameterOption('--auto-update', true) && ! $this->isTruthyAutoUpdateMode($autoUpdateMode)) {
             return;

src/Path/ManagedWorkspace.php

@@ -19,6 +19,8 @@
 
 namespace FastForward\DevTools\Path;
 
+use FastForward\DevTools\Environment\Environment;
+use FastForward\DevTools\Environment\EnvironmentInterface;
 use Symfony\Component\Filesystem\Path;
 
 /**
@@ -80,10 +82,14 @@ final class ManagedWorkspace
      *
      * @param string $path the optional relative segment to append under the managed output root
      * @param string $baseDir the optional repository root used to resolve the managed workspace path
+     * @param EnvironmentInterface|null $environment explicit environment reader used to resolve FAST_FORWARD_WORKSPACE_DIR
      */
-    public static function getOutputDirectory(string $path = '', string $baseDir = ''): string
-    {
-        $baseDir = self::getWorkspaceRoot($baseDir);
+    public static function getOutputDirectory(
+        string $path = '',
+        string $baseDir = '',
+        ?EnvironmentInterface $environment = null,
+    ): string {
+        $baseDir = self::getWorkspaceRoot(baseDir: $baseDir, environment: $environment);
 
         return '' === $path
             ? $baseDir
@@ -99,10 +105,14 @@ public static function getOutputDirectory(string $path = '', string $baseDir = '
      *
      * @param string $path the optional relative cache segment to append under the managed cache root
      * @param string $baseDir the optional repository root used to resolve the managed cache path
+     * @param EnvironmentInterface|null $environment explicit environment reader used to resolve FAST_FORWARD_WORKSPACE_DIR
      */
-    public static function getCacheDirectory(string $path = '', string $baseDir = ''): string
-    {
-        $baseDir = self::getOutputDirectory(self::CACHE_ROOT, $baseDir);
+    public static function getCacheDirectory(
+        string $path = '',
+        string $baseDir = '',
+        ?EnvironmentInterface $environment = null,
+    ): string {
+        $baseDir = self::getOutputDirectory(path: self::CACHE_ROOT, baseDir: $baseDir, environment: $environment);
 
         return '' === $path
             ? $baseDir
@@ -117,12 +127,17 @@ public static function getCacheDirectory(string $path = '', string $baseDir = ''
      * under that base directory while absolute workspaces are used as-is.
      *
      * @param string $baseDir the optional repository root used to resolve a relative workspace
+     * @param EnvironmentInterface|null $environment explicit environment reader used to resolve FAST_FORWARD_WORKSPACE_DIR
      */
-    public static function getWorkspaceRoot(string $baseDir = ''): string
-    {
-        $workspaceRoot = getenv(self::ENV_WORKSPACE_DIR);
+    public static function getWorkspaceRoot(
+        string $baseDir = '',
+        ?EnvironmentInterface $environment = null,
+    ): string {
+        $environment ??= new Environment();
 
-        if (false === $workspaceRoot || '' === $workspaceRoot) {
+        $workspaceRoot = $environment->get(self::ENV_WORKSPACE_DIR);
+
+        if (null === $workspaceRoot || '' === $workspaceRoot) {
             $workspaceRoot = self::WORKSPACE_ROOT;
         }
 
@@ -138,17 +153,25 @@ public static function getWorkspaceRoot(string $baseDir = ''): string
      * should skip generated artifacts during source scans.
      *
      * @param string $baseDir the optional repository root used to relativize absolute workspace paths
+     * @param EnvironmentInterface|null $environment explicit environment reader used for tests
      */
-    public static function getProjectRelativeWorkspaceRoot(string $baseDir = ''): ?string
-    {
-        $workspaceRoot = self::getWorkspaceRoot();
-
-        if (! Path::isAbsolute($workspaceRoot)) {
-            return $workspaceRoot;
+    public static function getProjectRelativeWorkspaceRoot(
+        string $baseDir = '',
+        ?EnvironmentInterface $environment = null,
+    ): ?string {
+        $environment ??= new Environment();
+        $workspaceRoot = $environment->get(self::ENV_WORKSPACE_DIR);
+
+        if (null === $workspaceRoot || '' === $workspaceRoot) {
+            $workspaceRoot = self::WORKSPACE_ROOT;
         }
 
         if ('' === $baseDir) {
-            return null;
+            return Path::isAbsolute($workspaceRoot) ? null : $workspaceRoot;
+        }
+
+        if (! Path::isAbsolute($workspaceRoot)) {
+            return $workspaceRoot;
         }
 
         $baseDir = Path::canonicalize($baseDir);

src/Path/WorkingProjectPathResolver.php

@@ -19,6 +19,7 @@
 
 namespace FastForward\DevTools\Path;
 
+use FastForward\DevTools\Environment\EnvironmentInterface;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Filesystem\Path;
 
@@ -64,14 +65,17 @@ public static function getProjectPath(string $path = ''): string
      * Returns the project directories that static-analysis and coding-style tooling SHOULD skip.
      *
      * @param string $baseDir the optional repository base directory used to materialize absolute paths
+     * @param EnvironmentInterface|null $environment explicit environment reader used to resolve FAST_FORWARD_WORKSPACE_DIR
      *
      * @return list<string>
      */
-    public static function getToolingExcludedDirectories(string $baseDir = ''): array
-    {
+    public static function getToolingExcludedDirectories(
+        string $baseDir = '',
+        ?EnvironmentInterface $environment = null,
+    ): array {
         $directories = [];
 
-        foreach (self::getToolingExcludedDirectoryNames($baseDir) as $excludedDirectory) {
+        foreach (self::getToolingExcludedDirectoryNames($baseDir, $environment) as $excludedDirectory) {
             $directories[] = Path::join($baseDir, $excludedDirectory);
         }
 
@@ -82,13 +86,16 @@ public static function getToolingExcludedDirectories(string $baseDir = ''): arra
      * Returns PHP source files that tooling SHOULD inspect without traversing generated directories.
      *
      * @param string $baseDir the optional repository base directory used to materialize absolute paths
+     * @param EnvironmentInterface|null $environment explicit environment reader used to resolve FAST_FORWARD_WORKSPACE_DIR
      *
      * @return list<string>
      */
-    public static function getToolingSourcePaths(string $baseDir = ''): array
-    {
+    public static function getToolingSourcePaths(
+        string $baseDir = '',
+        ?EnvironmentInterface $environment = null,
+    ): array {
         $workingDirectory = '' === $baseDir ? getcwd() : $baseDir;
-        $excludedDirectories = self::getToolingExcludedDirectoryNames($workingDirectory);
+        $excludedDirectories = self::getToolingExcludedDirectoryNames($workingDirectory, $environment);
         $finder = Finder::create()
             ->files()
             ->name('*.php')
@@ -115,13 +122,19 @@ public static function getToolingSourcePaths(string $baseDir = ''): array
      * Returns repository-relative directories ignored by tooling.
      *
      * @param string $baseDir the optional repository base directory used to relativize a custom workspace
+     * @param EnvironmentInterface|null $environment explicit environment reader used to resolve FAST_FORWARD_WORKSPACE_DIR
      *
      * @return list<string>
      */
-    private static function getToolingExcludedDirectoryNames(string $baseDir = ''): array
-    {
+    private static function getToolingExcludedDirectoryNames(
+        string $baseDir = '',
+        ?EnvironmentInterface $environment = null,
+    ): array {
         $directories = self::TOOLING_EXCLUDED_DIRECTORIES;
-        $workspaceRoot = ManagedWorkspace::getProjectRelativeWorkspaceRoot($baseDir);
+        $workspaceRoot = ManagedWorkspace::getProjectRelativeWorkspaceRoot(
+            baseDir: $baseDir,
+            environment: $environment
+        );
 
         if (null !== $workspaceRoot && ! \in_array($workspaceRoot, $directories, true)) {
             $directories[] = $workspaceRoot;

src/Project/ProjectCapabilities.php

@@ -128,6 +128,6 @@ public function canGenerateWiki(): bool
      */
     public function canRunTests(): bool
     {
-        return $this->hasTestsPath || $this->hasPhpSourceFiles;
+        return $this->hasPhpSourceFiles;
     }
 }