Invert search logic

[Konstantin8105]

Hello,

In according to that code:

chromem-go/query.go

Lines 145 to 160 in f63964a

	for k, v := range whereDocument {
	switch k {
	case "$contains":
	if !strings.Contains(document.Content, v) {
	return false
	}
	case "$not_contains":
	if strings.Contains(document.Content, v) {
	return false
	}
	default:
	// No handling (error) required because we already validated the
	// operators. This simplifies the concurrency logic (no err var
	// and lock, no context to cancel).
	}
	}

we can create only simply filter, for example:

whereDocument =map[string]string{
"$contains":"word1",
"$not_contains", "word2",
}

but if we invert key-value, then we can more complex query. Example of code:

 for k, v := range whereDocument { 
 	switch v { // <----
 	case "$contains": 
 		if !strings.Contains(document.Content, k) { // <----
 			return false 
 		} 
 	case "$not_contains": 
 		if strings.Contains(document.Content, k) { // <----
 			return false 
 		} 
 	default: 
 		// No handling (error) required because we already validated the 
 		// operators. This simplifies the concurrency logic (no err var 
 		// and lock, no context to cancel). 
 	} 
 } 

Thank you.

[Konstantin8105]

In my point of view, we can change function to more flexibility, because all Document with share variables.

from:

func documentMatchesFilters(document *Document, where, whereDocument map[string]string) bool {

to use filter pattern:

func documentMatchesFilters(document *Document, filter func(doc Document)(store bool) ) bool {
....
}

[philippgille]

Hi 👋 , Indeed the current implementation is very limiting. The inversion suggestion is interesting as it would be a small change with a big impact on the functionality. The filter function also makes sense.

I'll think about whether it's worth introducing a breaking change, or how to make it backwards compatible.

[Konstantin8105]

Feel free for close.

[philippgille]

No it's a good point, I just have to decide whether to go with inversion or the func or both, and whether to keep the existing functionality in addition for backwards compatibility.