Skip to content

Commit 6c2c0c6

Browse files
pdbethkeclaude
andcommitted
fix(tests): the matrix survey lets 'no template configured' skip, not fail
_survey() caught every exception per cell as 'a crash is a gap too', which swallowed the provider's FileNotFoundError on a machine with no HERO Designer template — CI — and reported 7,924 phantom disagreements. The conftest hook already turns that one error into a skip; the survey now re-raises it so the hook can. Reproduced with the local template hidden: 608 passed / 1,085 skipped / exit 0, where CI had 1 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PrVDXgpDfQpzEGErZTLjEs
1 parent 9bc1c45 commit 6c2c0c6

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

tests/test_included_matrix.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ def _survey() -> dict[str, str]:
3737
for c in cells():
3838
try:
3939
allowed, reason = _verdict(c)
40+
except FileNotFoundError:
41+
# "No HERO Designer template configured" is not a verdict; let it
42+
# reach conftest's hook, which turns it into a skip (CI has no
43+
# template). Swallowing it here counted 7,924 phantom gaps.
44+
raise
4045
except Exception as e: # noqa: BLE001 -- a crash is a gap too
4146
wrong[cell_key(c["modifier"], c["power"])] = f"raised {type(e).__name__}: {e}"
4247
continue

0 commit comments

Comments
 (0)