chore: delete the 27 5E-only rule classes -- kirby-cost is a 6E engine

PeterB, 2026-08-29: 6E only. These are Hero Designer's Java classes for
rules that exist in Main.hdt (5E) and not in Main6E.hdt -- Armor, Damage
Resistance, Find Weakness, Lack of Weakness, Succor, Suppress, Transfer,
the three Negative Skill Levels, N-Ray Perception; and the modifiers
Activation Roll, AVLD, BOECV, Damage Shield, Delayed END, Double END
Cost, Dropped, END Reserve Or END, Lingering, Others Only, Real Weapon,
Required Hands, Semi-Armor-Piercing, Transparent, Variable Targets and
Does Not Provide Mental Awareness. None appears in any of the 655 corpus
characters; a 6E corpus cannot reach them by definition.

Every runtime reference was checked before deletion. All but a handful
were xmlid STRING checks (find_object_by_id(..., "ENDRESERVEOREND")),
which survive untouched. The class references removed: isinstance
tuples in Cumulative, Autofire, No Range Modifier and Half Range
Modifier's included(); the Damage Resistance fold in
DefenseCharacteristic.calc_defense_resistance (6E does resistant defense
through Resistant Protection); two behaviors-registry entries; sixteen
modifier_map entries; and one test that constructed ActivationRoll.

Recoverable from git and from the Java source in kirby-hd-oracle.

Author: pdbethke

kirby_cost/behaviors/registry.py

@@ -63,15 +63,13 @@ def _load_class_fallbacks(self):
         class_mappings = {
             'ABSORPTION': ('absorption', 'Absorption'),
             'AID': ('aid', 'Aid'),
-            'ARMOR': ('armor', 'Armor'),
             'CHANGEENVIRONMENT': ('change_environment', 'ChangeEnvironment'),
             'CLAIRSENTIENCE': ('clairsentience', 'Clairsentience'),
             'CLINGING': ('clinging', 'Clinging'),
             'COMPOUNDPOWER': ('compound_power', 'CompoundPower'),
             'CUSTOMPOWER': ('custom_power', 'CustomPower'),
             'DAMAGENEGATION': ('damage_negation', 'DamageNegation'),
             'DAMAGEREDUCTION': ('damage_reduction', 'DamageReduction'),
-            'DAMAGERESISTANCE': ('damage_resistance', 'DamageResistance'),
             'DARKNESS': ('darkness', 'Darkness'),
             'DENSITYINCREASE': ('density_increase', 'DensityIncrease'),
             'DESOLIDIFICATION': ('desolidification', 'Desolidification'),

kirby_cost/objects/_registry_imports.py

@@ -8,29 +8,27 @@
 # ── Powers ──────────────────────────────────────────────────────────
 from kirby_cost.objects.powers import (  # noqa: F401
     absorption, active_sonar, adjacent, adjacent_fixed, aid, analyze_sense,
-    armor, automaton, change_environment, clairsentience, clinging,
+    automaton, change_environment, clairsentience, clinging,
     compound_power, concealed, custom_power, damage_negation, damage_reduction,
-    damage_resistance, darkness, density_increase, desolidification, detect,
+    darkness, density_increase, desolidification, detect,
     differing_modifier, dimensional_all, dimensional_group, dimensional_single,
     discriminatory_sense, dispel, does_not_bleed, drain, duplication,
     ego_attack, endurance_reserve, endurance_reserve_recovery,
     energy_blast, enhanced_perception, entangle, extra_dimensional_movement,
-    extra_limbs, find_weakness, fixed_location, flash, flash_defense,
+    extra_limbs, fixed_location, flash, flash_defense,
     floating_location, flight, force_field, force_wall, ftl_travel, gliding,
     growth, hand_to_hand_attack, healing, high_range_radio_perception,
     images, infrared_perception, invisibility, kb_resistance,
-    killing_attack_hth, killing_attack_ranged, lack_of_weakness,
-    life_support, luck, make_a_sense, mental_awareness, mental_defense,
+    killing_attack_hth, killing_attack_ranged, life_support, luck, make_a_sense, mental_awareness, mental_defense,
     mental_illusions, microscopic, mind_control, mind_link, mind_scan,
     missile_deflection, multiform, naked_modifier,
-    negative_combat_skill_levels, negative_penalty_skill_levels,
-    negative_skill_levels, nightvision, no_hit_locations,
-    nray_perception, partially_penetrative, penetrative, possession,
+    nightvision, no_hit_locations,
+    partially_penetrative, penetrative, possession,
     power_defense, presence_defense, radar, radio_perceive_transmit, radio_perception,
     range, rapid, reflection, regeneration, shapeshift, shrinking,
-    spatial_awareness, stretching, succor, summon, suppress, swinging,
+    spatial_awareness, stretching, summon, swinging,
     targeting_sense, telekinesis, telepathy, teleportation, telescopic,
-    tracking_sense, transfer, transmit, transform, tunneling,
+    tracking_sense, transmit, transform, tunneling,
     ultrasonic_perception, ultraviolet_perception,
 )
 
@@ -70,28 +68,26 @@
 
 # ── Modifiers ───────────────────────────────────────────────────────
 from kirby_cost.objects.modifiers import (  # noqa: F401
-    activationroll, affectsdesolid, affectsphysicalworld, alwayson,
-    alternatecombatvalue, areaeffect, armorpiercing, autofire, avad, avld,
-    basedonecv, beam, canbemissiledeflected, cannotescapewithteleport,
+    affectsdesolid, affectsphysicalworld, alwayson,
+    alternatecombatvalue, areaeffect, armorpiercing, autofire, avad, beam, canbemissiledeflected, cannotescapewithteleport,
     charges, concentration, continuous, costsend, costsendtomaintain,
-    costsendonlytoactivate, cumulative, damage_shield, damageovertime,
-    delayedeffect, delayedend, delayedreturnrate, difficulttodispel,
-    does_body, does_kb, doublekb, doubleendurancecost, dropped,
-    endreserveorend, explosion, extratime, feedback, focus, gestures,
+    costsendonlytoactivate, cumulative, damageovertime,
+    delayedeffect, delayedreturnrate, difficulttodispel,
+    does_body, does_kb, doublekb, explosion, extratime, feedback, focus, gestures,
     halfrangemodifier, hardened, holeinthemiddle, incantations,
     increasedend, increasedmaxrange, indirect, inherent, instant,
-    invisible, limitedarcoffire, limitedrange, lingering, linked,
+    invisible, limitedarcoffire, limitedrange, linked,
     lineofsight, megascale, mobile, nnd, no_kb, norange, norangemodifier,
     normalrange, nonpersistent, notthroughmindlink,
-    doesnotprovidementalawareness, onlyonappropriateterrain,
-    onlytoactivate, onlytostarting, others_only, partialcoverage,
+    onlyonappropriateterrain,
+    onlytoactivate, onlytostarting, partialcoverage,
     penetrating, persistent, personalimmunity, physicalmanifestation,
-    ranged, rangebasedonstr, realweapon, reducedbyrange, reducedend,
-    requiredhands, requiresskillroll, restrainable, self_only,
-    semiarmorpiercing, sideeffects, sticky, subjecttorangemodifier,
-    timelimit, transdimensional, transparent, trigger, turnmode,
+    ranged, rangebasedonstr, reducedbyrange, reducedend,
+    requiresskillroll, restrainable, self_only,
+    sideeffects, sticky, subjecttorangemodifier,
+    timelimit, transdimensional, trigger, turnmode,
     uncontrolled, usableonothers, variableadvantage, variableeffect,
-    variablelimitations, variabletarget, visible,
+    variablelimitations, visible,
 )
 
 # ── Martial Arts ────────────────────────────────────────────────────

kirby_cost/objects/characteristics/defense_characteristic.py

@@ -18,7 +18,6 @@
     from kirby_cost.io.hdc_loader import LoadedHero as Hero  # the live hero type
     from kirby_cost.objects.powers.compound_power import CompoundPower
     from kirby_cost.objects.powers.power import Power
-    from kirby_cost.objects.powers.damage_resistance import DamageResistance
     from kirby_cost.objects.talents.combat_luck import CombatLuck
 
 
@@ -31,7 +30,6 @@ class DefenseCharacteristic(Characteristic):
         _DEFENSE_LABEL: short label for display_notes (e.g. "PD")
         _COMBAT_LUCK_INCREASE_ATTR: CombatLuck attribute for increase (e.g. "pd_increase")
         _COMBAT_LUCK_INCREASE_LEVELS_ATTR: CombatLuck attribute for increase_levels
-        _DAMAGE_RESISTANCE_LEVELS_ATTR: DamageResistance attribute (e.g. "pd_levels")
         _RESISTANCE_CHECK_INCLUDES_IS_RESISTANT: bool - PD checks `and not self.is_resistant`
             in calc_resistance, ED does not.
     """
@@ -41,7 +39,6 @@ class DefenseCharacteristic(Characteristic):
     _DEFENSE_LABEL: str
     _COMBAT_LUCK_INCREASE_ATTR: str
     _COMBAT_LUCK_INCREASE_LEVELS_ATTR: str
-    _DAMAGE_RESISTANCE_LEVELS_ATTR: str
     _RESISTANCE_CHECK_INCLUDES_IS_RESISTANT: bool = True
 
     def __init_subclass__(cls, xmlid: str = "", **kwargs):
@@ -79,10 +76,6 @@ def _combat_luck_increase_levels(self, combat_luck: 'CombatLuck') -> int:
         """Get the defense-specific increase_levels from a CombatLuck instance."""
         return getattr(combat_luck, self._COMBAT_LUCK_INCREASE_LEVELS_ATTR)
 
-    def _damage_resistance_levels(self, dr: 'DamageResistance') -> int:
-        """Get the defense-specific levels from a DamageResistance instance."""
-        return getattr(dr, self._DAMAGE_RESISTANCE_LEVELS_ATTR)
-
     # ------------------------------------------------------------------
     # Iteration helper
     # ------------------------------------------------------------------
@@ -168,7 +161,6 @@ def calc_base_value(self, active_hero: Optional['Hero'] = None) -> None:
     def calc_defense_resistance(self, active_hero: Optional['Hero'] = None) -> None:
         """Calculate defense resistance."""
         from kirby_cost.objects.powers.compound_power import CompoundPower
-        from kirby_cost.objects.powers.damage_resistance import DamageResistance
 
         n3 = 0
 
@@ -179,10 +171,6 @@ def calc_defense_resistance(self, active_hero: Optional['Hero'] = None) -> None:
             # Check powers and equipment; for CompoundPower, process sub-powers directly
             for source in (active_hero.powers, getattr(active_hero, 'equipment', [])):
                 for item in source:
-                    if isinstance(item, DamageResistance):
-                        n3 += self._damage_resistance_levels(item)
-                        continue
-
                     if item.xmlid == self.xmlid:
                         def_char = item
                         if self.is_resistant:
@@ -206,10 +194,6 @@ def calc_defense_resistance(self, active_hero: Optional['Hero'] = None) -> None:
 
                     if isinstance(item, CompoundPower):
                         for sub_power in item.powers:
-                            if isinstance(sub_power, DamageResistance):
-                                n3 += self._damage_resistance_levels(sub_power)
-                                continue
-
                             if sub_power.xmlid != self.xmlid:
                                 continue
 

kirby_cost/objects/characteristics/energy_defense.py

@@ -15,7 +15,6 @@ class EnergyDefense(DefenseCharacteristic, xmlid="ED"):
     _DEFENSE_LABEL = "ED"
     _COMBAT_LUCK_INCREASE_ATTR = "ed_increase"
     _COMBAT_LUCK_INCREASE_LEVELS_ATTR = "ed_increase_levels"
-    _DAMAGE_RESISTANCE_LEVELS_ATTR = "ed_levels"
     _RESISTANCE_CHECK_INCLUDES_IS_RESISTANT = False
 
     # Backward-compatible aliases for the unified internal names

kirby_cost/objects/characteristics/physical_defense.py

@@ -15,7 +15,6 @@ class PhysicalDefense(DefenseCharacteristic, xmlid="PD"):
     _DEFENSE_LABEL = "PD"
     _COMBAT_LUCK_INCREASE_ATTR = "pd_increase"
     _COMBAT_LUCK_INCREASE_LEVELS_ATTR = "pd_increase_levels"
-    _DAMAGE_RESISTANCE_LEVELS_ATTR = "pd_levels"
     _RESISTANCE_CHECK_INCLUDES_IS_RESISTANT = True
 
     # Backward-compatible aliases for the unified internal names

kirby_cost/objects/modifier.py

@@ -422,44 +422,31 @@ def get_instance(element):
             "HALFRANGEMODIFIER": "HalfRangeModifier",
             "DAMAGEOVERTIME": "DamageOverTime",
             "AVAD": "AVAD",
-            "DOUBLEENDCOST": "DoubleEnduranceCost",
             "PHYSICALMANIFESTATION": "PhysicalManifestation",
-            "TRANSPARENT": "Transparent",
-            "SEMIARMORPIERCING": "SemiArmorPiercing",
             "PARTIALCOVERAGE": "PartialCoverage",
             "NOTELEPORT": "CannotEscapeWithTeleport",
             "LIMITEDARCOFFIRE": "LimitedArcOfFire",
-            "REQUIREDHANDS": "RequiredHands",
-            "REALWEAPON": "RealWeapon",
             "MOBILE": "Mobile",
-            "LINGERING": "Lingering",
-            "VARIABLETARGETS": "VariableTarget",
             "FEEDBACK": "Feedback",
             "ONLYONAPPROPRIATETERRAIN": "OnlyOnAppropriateTerrain",
-            "DROPPED": "Dropped",
             "DELAYEDRETURNRATE": "DelayedReturnRate",
             "VARIABLEEFFECT": "VariableEffect",
             "ONLYTOSTARTING": "OnlyToStarting",
             "SELFONLY": "SelfOnly",
-            "OTHERSONLY": "OthersOnly",
             "BEAM": "Beam",
             "CANBEMISSILEDEFLECTED": "CanBeMissileDeflected",
             "NOKB": "NoKB",
             "COSTSENDONLYTOACTIVATE": "CostsENDOnlyToActivate",
             "HARDENED": "Hardened",
-            "DOESNOTPROVIDEMENTALAWARENESS": "DoesNotProvideMentalAwareness",
             "NOTTHROUGHMINDLINK": "NotThroughMindLink",
             "COSTSENDTOMAINTAIN": "CostsENDToMaintain",
             "NORMALRANGE": "NormalRange",
             "TURNMODE": "TurnMode",
             "AFFECTSDESOLID": "AffectsDesolid",
             "AOE": "AreaEffect",
             "ARMORPIERCING": "ArmorPiercing",
-            "AVLD": "AVLD",
             "AUTOFIRE": "Autofire",
-            "BOECV": "BasedOnECV",
             "CUMULATIVE": "Cumulative",
-            "DAMAGESHIELD": "DamageShield",
             "DELAYEDEFFECT": "DelayedEffect",
             "DIFFICULTTODISPEL": "DifficultToDispel",
             "DOESBODY": "DoesBODY",
@@ -481,7 +468,6 @@ def get_instance(element):
             "NORANGEMODIFIER": "NoRangeModifier",
             "RANGED": "Ranged",
             "REDUCEDEND": "ReducedEND",
-            "DELAYEDEND": "DelayedEND",
             "STICKY": "Sticky",
             "TRANSDIMENSIONAL": "Transdimensional",
             "TRIGGER": "Trigger",
@@ -491,9 +477,7 @@ def get_instance(element):
             "VARIABLELIMITATIONS": "VariableLimitations",
             "VISIBLE": "Visible",
             "AFFECTSPHYSICALWORLD": "AffectsPhysicalWorld",
-            "ENDRESERVEOREND": "ENDReserveOrEND",
             "ACV": "AlternateCombatValue",
-            "ACTIVATIONROLL": "ActivationRoll",
             "ALWAYSON": "AlwaysOn",
             "CHARGES": "Charges",
             "CONCENTRATION": "Concentration",

kirby_cost/objects/modifiers/__init__.py

@@ -8,16 +8,13 @@
 
 # Import all specific modifier types
 from kirby_cost.objects.modifiers.avad import AVAD
-from kirby_cost.objects.modifiers.avld import AVLD
-from kirby_cost.objects.modifiers.activationroll import ActivationRoll
 from kirby_cost.objects.modifiers.affectsdesolid import AffectsDesolid
 from kirby_cost.objects.modifiers.affectsphysicalworld import AffectsPhysicalWorld
 from kirby_cost.objects.modifiers.alternatecombatvalue import AlternateCombatValue
 from kirby_cost.objects.modifiers.alwayson import AlwaysOn
 from kirby_cost.objects.modifiers.areaeffect import AreaEffect
 from kirby_cost.objects.modifiers.armorpiercing import ArmorPiercing
 from kirby_cost.objects.modifiers.autofire import Autofire
-from kirby_cost.objects.modifiers.basedonecv import BasedOnECV
 from kirby_cost.objects.modifiers.beam import Beam
 from kirby_cost.objects.modifiers.canbemissiledeflected import CanBeMissileDeflected
 from kirby_cost.objects.modifiers.cannotescapewithteleport import CannotEscapeWithTeleport
@@ -29,18 +26,12 @@
 from kirby_cost.objects.modifiers.costsendtomaintain import CostsENDToMaintain
 from kirby_cost.objects.modifiers.cumulative import Cumulative
 from kirby_cost.objects.modifiers.damageovertime import DamageOverTime
-from kirby_cost.objects.modifiers.damage_shield import DamageShield
-from kirby_cost.objects.modifiers.delayedend import DelayedEND
 from kirby_cost.objects.modifiers.delayedeffect import DelayedEffect
 from kirby_cost.objects.modifiers.delayedreturnrate import DelayedReturnRate
 from kirby_cost.objects.modifiers.difficulttodispel import DifficultToDispel
 from kirby_cost.objects.modifiers.does_body import DoesBODY
 from kirby_cost.objects.modifiers.does_kb import DoesKB
-from kirby_cost.objects.modifiers.doesnotprovidementalawareness import DoesNotProvideMentalAwareness
-from kirby_cost.objects.modifiers.doubleendurancecost import DoubleEnduranceCost
 from kirby_cost.objects.modifiers.doublekb import DoubleKB
-from kirby_cost.objects.modifiers.dropped import Dropped
-from kirby_cost.objects.modifiers.endreserveorend import ENDReserveOrEND
 from kirby_cost.objects.modifiers.explosion import Explosion
 from kirby_cost.objects.modifiers.extratime import ExtraTime
 from kirby_cost.objects.modifiers.feedback import Feedback
@@ -59,7 +50,6 @@
 from kirby_cost.objects.modifiers.limitedarcoffire import LimitedArcOfFire
 from kirby_cost.objects.modifiers.limitedrange import LimitedRange
 from kirby_cost.objects.modifiers.lineofsight import LineOfSight
-from kirby_cost.objects.modifiers.lingering import Lingering
 from kirby_cost.objects.modifiers.linked import Linked
 from kirby_cost.objects.modifiers.megascale import Megascale
 from kirby_cost.objects.modifiers.mobile import Mobile
@@ -73,51 +63,42 @@
 from kirby_cost.objects.modifiers.onlyonappropriateterrain import OnlyOnAppropriateTerrain
 from kirby_cost.objects.modifiers.onlytoactivate import OnlyToActivate
 from kirby_cost.objects.modifiers.onlytostarting import OnlyToStarting
-from kirby_cost.objects.modifiers.others_only import OthersOnly
 from kirby_cost.objects.modifiers.partialcoverage import PartialCoverage
 from kirby_cost.objects.modifiers.penetrating import Penetrating
 from kirby_cost.objects.modifiers.persistent import Persistent
 from kirby_cost.objects.modifiers.personalimmunity import PersonalImmunity
 from kirby_cost.objects.modifiers.physicalmanifestation import PhysicalManifestation
 from kirby_cost.objects.modifiers.rangebasedonstr import RangeBasedOnSTR
 from kirby_cost.objects.modifiers.ranged import Ranged
-from kirby_cost.objects.modifiers.realweapon import RealWeapon
 from kirby_cost.objects.modifiers.reducedbyrange import ReducedByRange
 from kirby_cost.objects.modifiers.reducedend import ReducedEND
-from kirby_cost.objects.modifiers.requiredhands import RequiredHands
 from kirby_cost.objects.modifiers.requiresskillroll import RequiresSkillRoll
 from kirby_cost.objects.modifiers.restrainable import Restrainable
 from kirby_cost.objects.modifiers.self_only import SelfOnly
-from kirby_cost.objects.modifiers.semiarmorpiercing import SemiArmorPiercing
 from kirby_cost.objects.modifiers.sideeffects import SideEffects
 from kirby_cost.objects.modifiers.sticky import Sticky
 from kirby_cost.objects.modifiers.subjecttorangemodifier import SubjectToRangeModifier
 from kirby_cost.objects.modifiers.timelimit import TimeLimit
 from kirby_cost.objects.modifiers.transdimensional import Transdimensional
-from kirby_cost.objects.modifiers.transparent import Transparent
 from kirby_cost.objects.modifiers.trigger import Trigger
 from kirby_cost.objects.modifiers.turnmode import TurnMode
 from kirby_cost.objects.modifiers.uncontrolled import Uncontrolled
 from kirby_cost.objects.modifiers.usableonothers import UsableOnOthers
 from kirby_cost.objects.modifiers.variableadvantage import VariableAdvantage
 from kirby_cost.objects.modifiers.variableeffect import VariableEffect
 from kirby_cost.objects.modifiers.variablelimitations import VariableLimitations
-from kirby_cost.objects.modifiers.variabletarget import VariableTarget
 from kirby_cost.objects.modifiers.visible import Visible
 
 __all__ = [
     'Modifier',
     'AVAD',
-    'AVLD',
-    'ActivationRoll',
     'AffectsDesolid',
     'AffectsPhysicalWorld',
     'AlternateCombatValue',
     'AlwaysOn',
     'AreaEffect',
     'ArmorPiercing',
     'Autofire',
-    'BasedOnECV',
     'Beam',
     'CanBeMissileDeflected',
     'CannotEscapeWithTeleport',
@@ -129,18 +110,12 @@
     'CostsENDToMaintain',
     'Cumulative',
     'DamageOverTime',
-    'DamageShield',
-    'DelayedEND',
     'DelayedEffect',
     'DelayedReturnRate',
     'DifficultToDispel',
     'DoesBODY',
     'DoesKB',
-    'DoesNotProvideMentalAwareness',
-    'DoubleEnduranceCost',
     'DoubleKB',
-    'Dropped',
-    'ENDReserveOrEND',
     'Explosion',
     'ExtraTime',
     'Feedback',
@@ -159,7 +134,6 @@
     'LimitedArcOfFire',
     'LimitedRange',
     'LineOfSight',
-    'Lingering',
     'Linked',
     'Megascale',
     'Mobile',
@@ -173,36 +147,30 @@
     'OnlyOnAppropriateTerrain',
     'OnlyToActivate',
     'OnlyToStarting',
-    'OthersOnly',
     'PartialCoverage',
     'Penetrating',
     'Persistent',
     'PersonalImmunity',
     'PhysicalManifestation',
     'RangeBasedOnSTR',
     'Ranged',
-    'RealWeapon',
     'ReducedByRange',
     'ReducedEND',
-    'RequiredHands',
     'RequiresSkillRoll',
     'Restrainable',
     'SelfOnly',
-    'SemiArmorPiercing',
     'SideEffects',
     'Sticky',
     'SubjectToRangeModifier',
     'TimeLimit',
     'Transdimensional',
-    'Transparent',
     'Trigger',
     'TurnMode',
     'Uncontrolled',
     'UsableOnOthers',
     'VariableAdvantage',
     'VariableEffect',
     'VariableLimitations',
-    'VariableTarget',
     'Visible',
 ]