fix tests

Author: erwanp

tests/test_yaml_comment_system.py

@@ -159,7 +159,7 @@ def test_update_yaml_preserving_comments(self, sample_yaml_with_comments):
                 "version": "2.0",
             },
             "simulation": {"end_time": 2.0, "dt": 0.02},
-            "components": [
+            "nodes": [
                 {
                     "id": "reactor1",
                     "IdealGasReactor": {
@@ -284,38 +284,36 @@ def test_comment_preservation_with_updates(self, sample_yaml_with_comments):
         assert "1300" in result_yaml  # Updated temperature
         assert "Updated Round Trip Test" in result_yaml
 
-    def test_stone_format_integration_with_comments(self, sample_yaml_with_comments):
-        """Test integration between STONE format and comment preservation."""
+    def test_stone_format_round_trip_with_comments(self, sample_yaml_with_comments):
+        """Test that STONE format configurations survive round-trip processing with comment preservation.
+
+        Expectation: After converting STONE→internal→STONE→comment preservation→YAML→reload,
+        the final configuration should contain the original reactor data with correct values.
+        """
         from boulder.config import normalize_config
 
-        # Load original YAML with comments
+        # Simulate the full application workflow for config processing
         original_data = load_yaml_string_with_comments(sample_yaml_with_comments)
-
-        # Convert to internal format (as the app does)
         internal_config = normalize_config(original_data)
-
-        # Convert back to STONE format (for editing)
         stone_config = convert_to_stone_format(internal_config)
-
-        # Update preserving original structure
         updated_data = _update_yaml_preserving_comments(original_data, stone_config)
-
-        # Convert back to YAML string
         final_yaml = yaml_to_string_with_comments(updated_data)
+        final_data = load_yaml_string_with_comments(final_yaml)
 
-        # Verify content is preserved
-        assert "test_reactor" in final_yaml
-        assert "1200" in final_yaml
+        # Single expectation: The test_reactor should exist with correct temperature and pressure values
+        assert "nodes" in final_data, "Final data should have nodes section"
+        assert len(final_data["nodes"]) > 0, "Should have at least one node"
 
-        # Load the final result to verify it's valid
-        final_data = load_yaml_string_with_comments(final_yaml)
-        # Check that the final data matches the expected STONE format
-        assert "nodes" in final_data
-        assert len(final_data["nodes"]) > 0
-        assert "IdealGasReactor" in final_data["nodes"][0]
-        assert final_data["nodes"][0]["id"] == "test_reactor"
-        assert final_data["nodes"][0]["IdealGasReactor"]["temperature"] == 1200.0
-        assert final_data["nodes"][0]["IdealGasReactor"]["pressure"] == 101325.0
+        node = final_data["nodes"][0]
+        assert node["id"] == "test_reactor", "Node ID should be preserved"
+
+        # After round-trip processing, we expect internal format (type and properties)
+        assert node["type"] == "IdealGasReactor", "Node type should be IdealGasReactor"
+        assert "properties" in node, "Node should have properties section"
+
+        reactor_data = node["properties"]
+        assert reactor_data["temperature"] == 1200.0, "Temperature should be preserved"
+        assert reactor_data["pressure"] == 101325.0, "Pressure should be preserved"
 
 
 class TestYAMLCommentIntegration: