Skip to content

OCPBUGS-84961: append suite names to external extension binary tests #31251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bshaw7 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Draft

OCPBUGS-84961: append suite names to external extension binary tests #31251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d3e22
OCPBUGS-84961: append suite names to external extension binary tests
bshaw7 Jun 2, 2026
14c7947
OCPBUGS-84961: apply full test processing pipeline to external binary…
bshaw7 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/test/extensions/binary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,15 @@ func (binaries TestBinaries) ListTests(ctx context.Context, parallelism int, env
return nil, fmt.Errorf("encountered errors while listing tests: %s", strings.Join(errs, ";"))
}

var baseSpecs extensiontests.ExtensionTestSpecs
for _, spec := range allTests {
baseSpecs = append(baseSpecs, spec.ExtensionTestSpec)
}
baseSpecs = filterOutDisabledSpecs(baseSpecs)
addEnvironmentSelectors(baseSpecs)
addLabelsToSpecs(baseSpecs)
appendSuiteNames(baseSpecs)
Comment on lines +950 to +957

@stbenjam stbenjam Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing test names breaks significant amount of tooling for historical comparison, you would have to account for these renames in openshift-eng/ci-test-mapping.

However, there is not a 1-to-1 linkage of "suite name" to "test". Tests are composable into many different kinds of suites, the pattern of including the name in tests should be something that goes away


return allTests, nil
}

Expand Down