Add CNO test extension binary by anuragthehatter · Pull Request #31218 · openshift/origin

anuragthehatter · 2026-05-27T02:29:28Z

Summary

Register the cluster-network-operator OTE binary in openshift-tests so it can discover and run CNO-specific e2e tests from the payload.

Depends-On: openshift/cluster-network-operator#3015

Test plan

Verify openshift-tests discovers the CNO extension binary
Verify CNO e2e tests are listed and runnable

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Extended test tooling to discover and extract an additional external test binary from cluster-network-operator release payloads, improving test coverage capabilities.
Chores
- Updated build/runtime base images used for the example container to newer OpenShift/RHEL toolchains, aligning builds with current platform versions.

Register the cluster-network-operator OTE binary so openshift-tests can discover and run CNO-specific e2e tests from the payload. Based on openshift/cluster-network-operator#3015 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-05-27T02:29:31Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

coderabbitai · 2026-05-27T02:29:50Z

Walkthrough

Adds a TestBinary mapping for the cluster-network-operator extension and updates the builder and runtime base image tags in the hello-openshift Dockerfile.

Changes

Extension Binary Registry & Dockerfile updates

Layer / File(s)	Summary
cluster-network-operator test binary registration `pkg/test/extensions/binary.go`	Added a `TestBinary` entry for `cluster-network-operator` that maps to `/usr/bin/cluster-network-operator-tests-ext.gz` in the `extensionBinaries` registry.
hello-openshift Dockerfile base image updates `images/hello-openshift/Dockerfile.rhel`	Updated the multi-stage builder and final runtime `FROM` image tags to newer RHEL9/Go and `ocp/4.22:base-rhel9` references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title 'Add CNO test extension binary' directly aligns with the primary change in pkg/test/extensions/binary.go, which adds a new external test binary mapping for cluster-network-operator.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR contains no Ginkgo test definitions. Changes are limited to a data structure configuration entry and a Dockerfile base image update.
Test Structure And Quality	✅ Passed	PR does not add Ginkgo test code. Changes register a test binary and update Docker base images. The check for Ginkgo test quality is not applicable.
Microshift Test Compatibility	✅ Passed	PR adds no new Ginkgo e2e tests. Changes are limited to registering a test extension binary in binary.go and updating Dockerfile base images; neither contains test definitions.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR registers external test binary for cluster-network-operator but does not add new Ginkgo e2e tests in openshift/origin. SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes are infrastructure-only: test extension registry update and base image version bump. No deployment manifests, operator code, or scheduling constraints present.
Ote Binary Stdout Contract	✅ Passed	PR only registers cluster-network-operator binary in extensionBinaries list. No process-level code changes. Logging properly configured via logs.InitLogs() before extension framework init.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests to openshift/origin. Changes are a binary mapping registration and Dockerfile base image update without test code.
No-Weak-Crypto	✅ Passed	The PR adds a CNO test binary mapping entry and updates Dockerfile base images. Neither file contains weak cryptographic algorithms, custom crypto implementations, or insecure secret comparisons.
Container-Privileges	✅ Passed	PR modifies a Go file and updates base images in a Dockerfile; neither are K8s manifests, and no privileged container configurations are present.
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive data exposure found. Changes add cluster-network-operator binary mapping and update Dockerfile base images; only non-sensitive operator names and registry URLs are logged.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-27T02:30:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-05-27T02:57:42Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

pperiyasamy · 2026-05-27T15:38:16Z

@anuragthehatter are you planning to test this PR with /testwith ?

anuragthehatter · 2026-06-04T14:19:50Z

/test e2e-gcp-ovn
/testwith openshift/cluster-network-operator#3015

anuragthehatter · 2026-06-04T14:23:19Z

/testwith openshift/ovn-kubernetes/master/e2e-aws-ovn-serial openshift/cluster-network-operator#3015

openshift-ci · 2026-06-04T14:23:24Z

@anuragthehatter, testwith: could not generate prow job. ERROR:

could not determine ci op config from metadata: got unexpected http 404 status code from configresolver: failed to get config: could not find any config for branch master on repo openshift/ovn-kubernetes

anuragthehatter · 2026-06-04T18:39:28Z

/retest

openshift-ci · 2026-06-04T18:59:54Z

@anuragthehatter: This PR was included in a payload test run from openshift/cluster-network-operator#3015
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8b7cea40-6047-11f1-8641-ad5566a4bfd8-0

openshift-ci · 2026-06-04T23:23:24Z

@anuragthehatter: This PR was included in a payload test run from openshift/cluster-network-operator#3015
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60210ff0-606c-11f1-9efc-61492c5af2a5-0

openshift-ci · 2026-06-05T01:13:52Z

@anuragthehatter: This PR was included in a payload test run from openshift/cluster-network-operator#3015
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cf346f40-607b-11f1-860f-f0487da5a3e9-0

anuragthehatter · 2026-06-05T15:10:16Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial #31218

openshift-ci · 2026-06-05T15:10:20Z

@anuragthehatter: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a8ec1de0-60f0-11f1-9180-a8ab45c2ee4d-0

openshift-ci · 2026-06-05T15:10:21Z

@anuragthehatter: This PR was included in a payload test run from #31218
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a8ec1de0-60f0-11f1-9180-a8ab45c2ee4d-0

openshift-merge-bot · 2026-06-05T15:39:44Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-trt · 2026-06-05T20:17:24Z

Job Failure Risk Analysis for sha: 214aaca

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi	IncompleteTests Tests for this run (81) are below the historical average (1817): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips	IncompleteTests Tests for this run (82) are below the historical average (3271): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift	IncompleteTests Tests for this run (28) are below the historical average (1805): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	IncompleteTests Tests for this run (28) are below the historical average (921): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2	IncompleteTests Tests for this run (81) are below the historical average (1952): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2	IncompleteTests Tests for this run (81) are below the historical average (1779): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi	IncompleteTests Tests for this run (78) are below the historical average (1938): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn	IncompleteTests Tests for this run (78) are below the historical average (3469): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade	IncompleteTests Tests for this run (78) are below the historical average (1979): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (72) are below the historical average (3356): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn	IncompleteTests Tests for this run (75) are below the historical average (3246): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi	IncompleteTests Tests for this run (74) are below the historical average (3352): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-ci · 2026-06-06T01:15:25Z

@anuragthehatter: This PR was included in a payload test run from openshift/cluster-network-operator#3015
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/30323330-6145-11f1-8085-18a113a858ae-0

openshift-merge-bot · 2026-06-06T01:30:36Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-06-06T03:17:40Z

@anuragthehatter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	`a289233`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/e2e-gcp-csi	`a289233`	link	true	`/test e2e-gcp-csi`
ci/prow/e2e-vsphere-ovn	`a289233`	link	true	`/test e2e-vsphere-ovn`
ci/prow/e2e-gcp-ovn-upgrade	`a289233`	link	true	`/test e2e-gcp-ovn-upgrade`
ci/prow/e2e-vsphere-ovn-upi	`a289233`	link	true	`/test e2e-vsphere-ovn-upi`
ci/prow/e2e-aws-ovn-serial-2of2	`a289233`	link	true	`/test e2e-aws-ovn-serial-2of2`
ci/prow/e2e-gcp-ovn	`a289233`	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-aws-csi	`a289233`	link	true	`/test e2e-aws-csi`
ci/prow/e2e-metal-ipi-ovn-ipv6	`a289233`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-aws-ovn-microshift	`a289233`	link	true	`/test e2e-aws-ovn-microshift`
ci/prow/e2e-aws-ovn-microshift-serial	`a289233`	link	true	`/test e2e-aws-ovn-microshift-serial`
ci/prow/e2e-aws-ovn-serial-1of2	`a289233`	link	true	`/test e2e-aws-ovn-serial-1of2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt · 2026-06-06T04:19:34Z

Job Failure Risk Analysis for sha: a289233

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi	IncompleteTests Tests for this run (82) are below the historical average (1801): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips	IncompleteTests Tests for this run (83) are below the historical average (3234): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift	IncompleteTests Tests for this run (29) are below the historical average (1789): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	IncompleteTests Tests for this run (29) are below the historical average (914): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2	IncompleteTests Tests for this run (82) are below the historical average (1931): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2	IncompleteTests Tests for this run (82) are below the historical average (1759): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi	IncompleteTests Tests for this run (79) are below the historical average (1922): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn	IncompleteTests Tests for this run (79) are below the historical average (3463): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade	IncompleteTests Tests for this run (79) are below the historical average (1962): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (73) are below the historical average (3314): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn	IncompleteTests Tests for this run (75) are below the historical average (3269): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi	IncompleteTests Tests for this run (75) are below the historical average (3315): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-ci · 2026-06-08T14:24:02Z

@anuragthehatter: This PR was included in a payload test run from openshift/cluster-network-operator#3015
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0e017d0-6345-11f1-9c80-ac8ee1ba40aa-0

openshift-ci · 2026-06-08T20:22:33Z

@anuragthehatter: This PR was included in a payload test run from openshift/cluster-network-operator#3015
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c28462b0-6377-11f1-805f-664899d5708f-0

openshift-ci · 2026-06-09T01:20:48Z

@anuragthehatter: This PR was included in a payload test run from openshift/cluster-network-operator#3015
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6a411290-63a1-11f1-8717-3fccd4afa0ed-0

Add CNO test extension binary

a289233

Register the cluster-network-operator OTE binary so openshift-tests can discover and run CNO-specific e2e tests from the payload. Based on openshift/cluster-network-operator#3015 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci Bot requested review from deads2k and sjenning May 27, 2026 02:30

coderabbitai Bot approved these changes May 27, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 27, 2026

anuragthehatter mentioned this pull request Jun 4, 2026

[CNO] Setup OTE framework and migrate test cases from tests-private openshift/cluster-network-operator#3015

Open

4 tasks

anuragthehatter force-pushed the cno-test-extension branch from 214aaca to a289233 Compare June 6, 2026 01:08

Conversation

anuragthehatter commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci Bot commented May 27, 2026

Uh oh!

openshift-merge-bot Bot commented May 27, 2026

Uh oh!

pperiyasamy commented May 27, 2026

Uh oh!

anuragthehatter commented Jun 4, 2026

Uh oh!

anuragthehatter commented Jun 4, 2026

Uh oh!

openshift-ci Bot commented Jun 4, 2026

Uh oh!

anuragthehatter commented Jun 4, 2026

Uh oh!

openshift-ci Bot commented Jun 4, 2026

Uh oh!

openshift-ci Bot commented Jun 4, 2026

Uh oh!

openshift-ci Bot commented Jun 5, 2026

Uh oh!

anuragthehatter commented Jun 5, 2026

Uh oh!

openshift-ci Bot commented Jun 5, 2026

Uh oh!

openshift-ci Bot commented Jun 5, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 5, 2026

Uh oh!

openshift-trt Bot commented Jun 5, 2026

Uh oh!

openshift-ci Bot commented Jun 6, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 6, 2026

Uh oh!

openshift-ci Bot commented Jun 6, 2026

Uh oh!

openshift-trt Bot commented Jun 6, 2026

Uh oh!

openshift-ci Bot commented Jun 8, 2026

Uh oh!

openshift-ci Bot commented Jun 8, 2026

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anuragthehatter commented May 27, 2026 •

edited

Loading

coderabbitai Bot commented May 27, 2026 •

edited

Loading