Update @odh-dashboard/model-registry: Fix the cold start filtering from being passed when the performance toggle is off (#2853)

Upstream commit: acdf0135544891be7e245017356b6731e5e01e56

Author: ppadti

packages/model-registry/package.json

@@ -23,7 +23,7 @@
     "branch": "main",
     "src": "clients/ui",
     "target": "upstream",
-    "commit": "5848ed75b70f288eebd6e9509e90b22ea9be34e2"
+    "commit": "acdf0135544891be7e245017356b6731e5e01e56"
   },
   "module-federation": {
     "name": "modelRegistry",

packages/model-registry/upstream/frontend/src/app/api/modelCatalog/service.ts

@@ -38,7 +38,9 @@ export const getCatalogModelsBySource =
   ): Promise<CatalogModelList> => {
     const computedFilterQuery =
       filterQuery ??
-      (filterData && filterOptions ? filtersToFilterQuery(filterData, filterOptions) : '');
+      (filterData && filterOptions
+        ? filtersToFilterQuery(filterData, filterOptions, 'models', !!performanceParams)
+        : '');
 
     const allParams = {
       source: sourceId,

packages/model-registry/upstream/frontend/src/app/pages/modelCatalog/utils/__tests__/modelCatalogUtils.spec.ts

@@ -489,6 +489,44 @@ describe('filtersToFilterQuery', () => {
       expect(query).toContain('modelcar_image_size.double_value <= 10');
     });
   });
+
+  describe('includeColdStartClause parameter', () => {
+    it('does not append cold-start OR clause when includeColdStartClause is false', () => {
+      const query = filtersToFilterQuery(
+        mockFormData({ tasks: [ModelCatalogTask.TEXT_TO_TEXT] }),
+        mockFilterOptions,
+        'models',
+        false,
+      );
+      expect(query).toBe("tasks='text-to-text'");
+      expect(query).not.toContain('performance_sub_type');
+      expect(query).not.toContain('cold-start');
+    });
+
+    it('appends cold-start OR clause when includeColdStartClause is true (default)', () => {
+      const query = filtersToFilterQuery(
+        mockFormData({ tasks: [ModelCatalogTask.TEXT_TO_TEXT] }),
+        mockFilterOptions,
+        'models',
+        true,
+      );
+      expect(query).toContain("OR artifacts.performance_sub_type.string_value='cold-start'");
+    });
+
+    it('does not append cold-start OR clause with multiple basic filters when performance is off', () => {
+      const query = filtersToFilterQuery(
+        mockFormData({
+          tasks: [ModelCatalogTask.TEXT_TO_TEXT],
+          provider: [ModelCatalogProvider.GOOGLE],
+        }),
+        mockFilterOptions,
+        'models',
+        false,
+      );
+      expect(query).toBe("tasks='text-to-text' AND provider='Google'");
+      expect(query).not.toContain('performance_sub_type');
+    });
+  });
 });
 
 describe('catalog source filtering utilities', () => {

packages/model-registry/upstream/frontend/src/app/pages/modelCatalog/utils/modelCatalogUtils.ts

@@ -456,13 +456,16 @@ const serializeFilterEntry = (
  * @param target - The target endpoint:
  *   - 'models': Include all filters (except RPS), use filter keys directly
  *   - 'artifacts': Only include artifact-prefixed filters, strip the prefix in output
+ * @param includeColdStartClause - Whether to append the cold-start OR clause.
+ *   Should be true only when performance view is enabled.
  *
  * Note: RPS is NOT included in filterQuery for either target - it's passed as targetRPS param.
  */
 export const filtersToFilterQuery = (
   filterData: ModelCatalogFilterStates,
   options: CatalogFilterOptionsList,
   target: FilterQueryTarget = 'models',
+  includeColdStartClause = true,
 ): string => {
   const serializedFilters: string[] = Object.entries(filterData)
     .filter(([filterId]) => shouldIncludeFilter(filterId, target))
@@ -474,6 +477,11 @@ export const filtersToFilterQuery = (
   }
 
   const baseQuery = nonEmptyFilters.join(' AND ');
+
+  if (!includeColdStartClause) {
+    return baseQuery;
+  }
+
   const coldStartClause = buildColdStartOrClause(filterData, options, target);
   return `${baseQuery} OR ${coldStartClause}`;
 };